Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752973AbdHQPMi (ORCPT ); Thu, 17 Aug 2017 11:12:38 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:37170 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbdHQPKn (ORCPT ); Thu, 17 Aug 2017 11:10:43 -0400 Date: Thu, 17 Aug 2017 10:10:39 -0500 From: Rob Herring To: Franklin S Cooper Jr Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de, quentin.schulz@free-electrons.com, dev.kurt@vandijck-laurijssen.be, andrew@lunn.ch, sergei.shtylyov@cogentembedded.com, socketcan@hartkopp.net Subject: Re: [PATCH v4 3/4] dt-bindings: can: m_can: Document new can transceiver binding Message-ID: <20170817140642.q6wxp2d6ss5h3yrp@rob-hp-laptop> References: <20170810005916.27163-1-fcooper@ti.com> <20170810005916.27163-4-fcooper@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170810005916.27163-4-fcooper@ti.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1564 Lines: 47 On Wed, Aug 09, 2017 at 07:59:15PM -0500, Franklin S Cooper Jr wrote: > Add information regarding can-transceiver binding. This is especially > important for MCAN since the IP allows CAN FD mode to run significantly > faster than what most transceivers are capable of. > > Signed-off-by: Franklin S Cooper Jr > --- > Drop unit address. > Switch from using fixed-transceiver to can-transceiver > Indicate that can-transceiver is an optional subnode not a property. > > Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt > index 9e33177..ee90aac 100644 > --- a/Documentation/devicetree/bindings/net/can/m_can.txt > +++ b/Documentation/devicetree/bindings/net/can/m_can.txt > @@ -43,6 +43,11 @@ Required properties: > Please refer to 2.4.1 Message RAM Configuration in > Bosch M_CAN user manual for details. > > +Optional Subnode: > +- can-transceiver : Can-transceiver subnode describing maximum speed > + that can be used for CAN/CAN-FD modes. See > + Documentation/devicetree/bindings/net/can/can-transceiver.txt > + for details. > Example: > SoC dtsi: > m_can1: can@020e8000 { > @@ -64,4 +69,8 @@ Board dts: > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_m_can1>; > status = "enabled"; > + > + can-transceiver@ { ditto Acked-by: Rob Herring > + max-bitrate = <5000000>; > + }; > }; > -- > 2.9.4.dirty >