Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753292AbdHQQ2N (ORCPT ); Thu, 17 Aug 2017 12:28:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37690 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbdHQQ2L (ORCPT ); Thu, 17 Aug 2017 12:28:11 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com C0A884E4D0 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jpoimboe@redhat.com Date: Thu, 17 Aug 2017 11:28:08 -0500 From: Josh Poimboeuf To: Joe Lawrence Cc: Petr Mladek , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Jessica Yu , Jiri Kosina , Miroslav Benes Subject: Re: [PATCH v4] livepatch: introduce shadow variable API Message-ID: <20170817162808.tcdky4z2qlj27co5@treble> References: <1502740963-31310-1-git-send-email-joe.lawrence@redhat.com> <1502740963-31310-2-git-send-email-joe.lawrence@redhat.com> <20170817140545.GF601@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 17 Aug 2017 16:28:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 479 Lines: 13 On Thu, Aug 17, 2017 at 12:01:33PM -0400, Joe Lawrence wrote: > Without a good real-world example, you've convinced me that > klp_shadow_update_or_attach() could be dropped. I think this will also > simplify the requirements of a shared __klp_shadow_get_or_attach() like > you sketched out earlier. > > If Josh and Miroslav don't mind, I'd like to continue churning this > patch with the suggestions that Petr has made. By all means, go ahead. I rescind my Ack ;-) -- Josh