Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753508AbdHQRyO (ORCPT ); Thu, 17 Aug 2017 13:54:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57706 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189AbdHQRyN (ORCPT ); Thu, 17 Aug 2017 13:54:13 -0400 Date: Thu, 17 Aug 2017 10:54:14 -0700 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established Message-ID: <20170817175414.GA32163@kroah.com> References: <20170815232339.26701-1-Badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170815232339.26701-1-Badhri@google.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 27 On Tue, Aug 15, 2017 at 04:23:39PM -0700, Badhri Jagan Sridharan wrote: > While in SNK_READY state, the explicit_contract seems to be > set to true irrespective of whether an explicit contract > was established for the current connection. TCPM also seems > to report the pwr_opmode as TYPEC_PWR_MODE_PD always once > the port gets into SNK_READY state. This isn't completely > true as port gets into the SNK_READY state for non-pd > type-c ports as well. > > This patch sets the explicit_contract flag only when > the PS_READY message is received and the vbus has been > detected by the port controller. > > Signed-off-by: Badhri Jagan Sridharan > Reviewed-by: Guenter Roeck > --- > drivers/staging/typec/tcpm.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) This patch doesn't apply to the tree now that Guenter's other patches are applied :( Please rebase and resend. thanks, greg k-h