Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753526AbdHQR5E (ORCPT ); Thu, 17 Aug 2017 13:57:04 -0400 Received: from mail-ua0-f180.google.com ([209.85.217.180]:36003 "EHLO mail-ua0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbdHQR5C (ORCPT ); Thu, 17 Aug 2017 13:57:02 -0400 MIME-Version: 1.0 In-Reply-To: <87pobuz4s2.fsf@hermes> References: <20170728105640.16268-1-lhenriques@suse.com> <87pobuz4s2.fsf@hermes> From: Ilya Dryomov Date: Thu, 17 Aug 2017 19:57:01 +0200 Message-ID: Subject: Re: [PATCH] ceph: check negative offsets on ceph_llseek() To: Luis Henriques Cc: "Yan, Zheng" , Sage Weil , Ceph Development , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 523 Lines: 19 On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: > Luis Henriques writes: > >> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >> ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for >> SEEK_DATA and 0 for SEEK_HOLE. > > Ping > > This patch should make xfstest generic/448 happy. It should or it does? ;) I saw generic/448 failures on ext4 with Darrick's recent test change, haven't tried ceph yet. Thanks, Ilya