Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753790AbdHQR6u (ORCPT ); Thu, 17 Aug 2017 13:58:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58412 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753355AbdHQR6t (ORCPT ); Thu, 17 Aug 2017 13:58:49 -0400 Date: Thu, 17 Aug 2017 10:58:50 -0700 From: Greg KH To: Ashish Kalra Cc: wsa@the-dreams.de, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, joe@perches.com Subject: Re: [PATCH v2]staging: ks7010: fix styling WARNINGs Message-ID: <20170817175850.GB5980@kroah.com> References: <1501604576.7190.7.camel@perches.com> <1501608336-9426-1-git-send-email-eashishkalra@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501608336-9426-1-git-send-email-eashishkalra@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 538 Lines: 16 On Tue, Aug 01, 2017 at 06:25:36PM +0100, Ashish Kalra wrote: > Signed-off-by: Ashish Kalra > > Trivial style changes. There are still "line over 80 characters" > checkpatch.pl warnings, but I think they are best left alone as > breaking these could hurt readability > v2: Updated Patch as per review comments recievd Why is all of this stuff below the signed-off-by line? Please fix this up properly, and read the documentation for how to submit a patch in Documentation/SubmittingPatches. thanks, greg k-h