Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753374AbdHQST3 (ORCPT ); Thu, 17 Aug 2017 14:19:29 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:36886 "EHLO mail-wr0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752236AbdHQST1 (ORCPT ); Thu, 17 Aug 2017 14:19:27 -0400 Subject: Re: [PATCH 3/3] mfd: d1w: iproc: Add d1w driver To: Lee Jones References: <1502905525-5646-1-git-send-email-scott.branden@broadcom.com> <1502905525-5646-4-git-send-email-scott.branden@broadcom.com> <20170817100206.tqb5kluje6nr27ob@dell> Cc: Greg Kroah-Hartman , BCM Kernel Feedback , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shreesha Rajashekar From: Scott Branden Message-ID: Date: Thu, 17 Aug 2017 11:19:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170817100206.tqb5kluje6nr27ob@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 28 Hi Lee, On 17-08-17 03:02 AM, Lee Jones wrote: > On Wed, 16 Aug 2017, Scott Branden wrote: > >> From: Shreesha Rajashekar >> >> d1w bus master controller is added as a mfd node. > Why? > >> ds1wm driver is hooked to this node through the mfd framework. > Why? It looks like it was added under mfd as htc-pasic3.c is there (other than htc-pasic3.c is and mfd due to gpio nodes). Yes, bcm-iproc-d1w should move under w1 directory. > > What makes this an MFD device? > >> Signed-off-by: Shreesha Rajashekar >> Signed-off-by: Scott Branden >> --- >> drivers/mfd/Kconfig | 11 +++ >> drivers/mfd/Makefile | 1 + >> drivers/mfd/bcm-iproc-d1w.c | 202 ++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 214 insertions(+) >> create mode 100644 drivers/mfd/bcm-iproc-d1w.c