Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753382AbdHQS16 (ORCPT ); Thu, 17 Aug 2017 14:27:58 -0400 Received: from mail-sg2apc01on0122.outbound.protection.outlook.com ([104.47.125.122]:35472 "EHLO APC01-SG2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751665AbdHQS14 (ORCPT ); Thu, 17 Aug 2017 14:27:56 -0400 From: Dexuan Cui To: David Miller CC: "jhansen@vmware.com" , "netdev@vger.kernel.org" , "gregkh@linuxfoundation.org" , "devel@linuxdriverproject.org" , KY Srinivasan , "Haiyang Zhang" , Stephen Hemminger , "georgezhang@vmware.com" , "mkubecek@suse.cz" , "asias@redhat.com" , "stefanha@redhat.com" , "vkuznets@redhat.com" , "cavery@redhat.com" , "jasowang@redhat.com" , "rolf.neugebauer@docker.com" , "dave.scott@docker.com" , "marcelo.cerri@canonical.com" , "apw@canonical.com" , "olaf@aepfle.de" , "joe@perches.com" , "linux-kernel@vger.kernel.org" , "dan.carpenter@oracle.com" Subject: RE: [PATCH] vsock: only load vmci transport on VMware hypervisor by default Thread-Topic: [PATCH] vsock: only load vmci transport on VMware hypervisor by default Thread-Index: AdMXLqHUpz8ZGmCVQCq3Yks74VajMAATDC+AAALVvDA= Date: Thu, 17 Aug 2017 18:27:30 +0000 Message-ID: References: <20170817.100401.864010589587308706.davem@davemloft.net> In-Reply-To: <20170817.100401.864010589587308706.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=True; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Ref=https://api.informationprotection.azure.com/api/72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Owner=decui@microsoft.com; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2017-08-17T11:27:28.6543509-07:00; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=General; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Application=Microsoft Azure Information Protection; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Extended_MSFT_Method=Automatic; Sensitivity=General authentication-results: spf=none (sender IP is ) smtp.mailfrom=decui@microsoft.com; x-originating-ip: [167.220.1.201] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;KL1P15301MB0006;6:uajBgMYZd5aK8TmtXu3wudHEjwrJjJoK+o2ctWIv9R0ghstVgLqydeCeKlCkqvB1OLGIbGA4yeLXIwKaRvS7EX7cmUXS1T837DJ9G478Q9wU3UyHF1yNeetXgEJYMP50059X3dwIqdim8CvAffjkTaD2gE84PCNZC2onuLaULbvBsSbsE2uxGn7zB99cN2EQzKSUoTyctyso58/vQRGzvDSstJZPbYrulX9blaKNWitKcokz0b1WqrQXQZHQP8Z0uClEs0Ps+5AOa1FbJiMUS1YJ5Xn2mvbxmiMSy25lhXzVLOoYy9yLRkd156czS+uYshhOEDqw2TyOU2Cc9NJ30w==;5:R6Hup1BaD1ENiJ+GgH4UuN2VVawIavmpP7yj2lYUTvLOmOF5UuXd/y/Nq2MWMas+B4aAcj8uyk8mNKz9n1Lp+sfYaFhvLDv8UUi43bEREn2Cx7lgHR9vVlOxrL2OoPenzppjL59Q4vCHVOlxpwmiz9/8x1/P0WCBrk/+wM2cM8o=;24:ZCPcQTqguNVAKEw6WsTqpPT77f9TOTr4ywk6XKNV0+/WJiB8ZHFmsQYCGNlu8dLbSjE+D9G8uvWnuvcKE9SmD7JRsEoCpd9xVze4QHB04k4=;7:xQVLnaVBXqGyOA9pxA1056qLSqbX0+jQCRhMRxpdNWCFA6Z0abKtXiwODdcSh3oRyDM7pH86kGfAiDcHPiUc+Lva+qfMmcXduBsQJgTKg7NKWcnqyzUqscL/5tm4ouXLZPlP2a0Fr0zXW5yqd7srNbr+is4LMW32ofMk3DhCYtutSXAnAA0pr4CzqLturISzvufXveuFN7Qe6Lns1kgaTI0hNBJPv1JulQ8yVGKkooU= x-ms-office365-filtering-correlation-id: b566f89b-f60b-4aba-7438-08d4e59d9f86 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:KL1P15301MB0006; x-ms-traffictypediagnostic: KL1P15301MB0006: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(61425038)(6040450)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(100000703101)(100105400095)(10201501046)(6055026)(61426038)(61427038)(6041248)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:KL1P15301MB0006;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:KL1P15301MB0006; x-forefront-prvs: 0402872DA1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(47760400005)(199003)(189002)(101416001)(6506006)(55016002)(54906002)(2900100001)(105586002)(106356001)(305945005)(2950100002)(102836003)(6916009)(6116002)(3846002)(54356999)(50986999)(77096006)(8990500004)(7736002)(76176999)(5005710100001)(229853002)(9686003)(6246003)(33656002)(81156014)(53936002)(8936002)(110136004)(81166006)(8676002)(6436002)(14454004)(2906002)(7696004)(97736004)(189998001)(478600001)(25786009)(4326008)(66066001)(10290500003)(3280700002)(86612001)(68736007)(3660700001)(10090500001)(86362001)(7416002)(5660300001)(74316002);DIR:OUT;SFP:1102;SCL:1;SRVR:KL1P15301MB0006;H:KL1P15301MB0008.APCP153.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2017 18:27:30.7753 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1P15301MB0006 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7HITIaY026883 Content-Length: 634 Lines: 19 > From: David Miller [mailto:davem@davemloft.net] > Sent: Thursday, August 17, 2017 10:04 > I would avoid module parameters at all costs. > > It is the worst possible interface for users of your software. > > You really need to fundamentally solve the problems related to making > sure the proper modules for the VM actually present on the system get > loaded when necessary rather than adding hacks like this. > > Unlike a proper solution, these hacks are ugly but have to stay around > forever once you put them in place. Sorry for reminding me again, David! :-) I'll try to figure out the correct solution. Thanks, -- Dexuan