Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbdHQSxu (ORCPT ); Thu, 17 Aug 2017 14:53:50 -0400 Received: from mx0a-00010702.pphosted.com ([148.163.156.75]:45535 "EHLO mx0b-00010702.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752270AbdHQSxs (ORCPT ); Thu, 17 Aug 2017 14:53:48 -0400 Date: Thu, 17 Aug 2017 13:53:27 -0500 From: Julia Cartwright To: Sebastian Andrzej Siewior CC: , , "Thomas Gleixner" , Carsten Emde , John Kacur , Steven Rostedt Subject: Re: [ANNOUNCE] 4.1.42-rt50 Message-ID: <20170817185327.GH8384@jcartwri.amer.corp.natinst.com> References: <20170816204228.GE8384@jcartwri.amer.corp.natinst.com> <20170817073027.xzkn7sn4cxki3lcr@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170817073027.xzkn7sn4cxki3lcr@linutronix.de> User-Agent: Mutt/1.8.3 (2017-05-23) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-17_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_policy_notspam policy=outbound_policy score=30 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=30 reason=mlx scancount=1 engine=8.0.1-1707230000 definitions=main-1708170304 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 34 On Thu, Aug 17, 2017 at 09:30:28AM +0200, Sebastian Andrzej Siewior wrote: > On 2017-08-16 15:42:28 [-0500], Julia Cartwright wrote: [..] > > diff --git a/kernel/cpu_pm.c b/kernel/cpu_pm.c > > index 9656a3c36503..9da42f83ee03 100644 > > --- a/kernel/cpu_pm.c > > +++ b/kernel/cpu_pm.c > > @@ -22,14 +22,13 @@ > > #include > > #include > > > > -static DEFINE_RWLOCK(cpu_pm_notifier_lock); > > -static RAW_NOTIFIER_HEAD(cpu_pm_notifier_chain); > > +static ATOMIC_NOTIFIER_HEAD(cpu_pm_notifier_chain); > > > > static int cpu_pm_notify(enum cpu_pm_event event, int nr_to_call, int *nr_calls) > > { > > int ret; > > > > - ret = __raw_notifier_call_chain(&cpu_pm_notifier_chain, event, NULL, > > + ret = __atomic_notifier_call_chain(&cpu_pm_notifier_chain, event, NULL, > > nr_to_call, nr_calls); > > there is a piece missing, upstream has a different change queued. I know > that this is the same as in latest RT, this is just to let you know in > case someone complains about an RCU backtrace??? Ah! Thanks. Indeed. I did see the upstream-queued version get cc'd to linux-rt-users, but didn't see the rcu_irq_{enter,exit}_irqson() addition, assuming it to be what landed in rt-devel. Will you be fixing this up in 4.11-rt? Julia