Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753727AbdHQTHg (ORCPT ); Thu, 17 Aug 2017 15:07:36 -0400 Received: from mail-oi0-f52.google.com ([209.85.218.52]:33220 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbdHQTHe (ORCPT ); Thu, 17 Aug 2017 15:07:34 -0400 MIME-Version: 1.0 In-Reply-To: <20170817175414.GA32163@kroah.com> References: <20170815232339.26701-1-Badhri@google.com> <20170817175414.GA32163@kroah.com> From: Badhri Jagan Sridharan Date: Thu, 17 Aug 2017 12:06:52 -0700 Message-ID: Subject: Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always established To: Greg Kroah-Hartman Cc: Guenter Roeck , devel@driverdev.osuosl.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 38 Greg, Sure. Resending the patch based on https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git staging-testing branch. Thanks, Badhri On Thu, Aug 17, 2017 at 10:54 AM, Greg Kroah-Hartman wrote: > On Tue, Aug 15, 2017 at 04:23:39PM -0700, Badhri Jagan Sridharan wrote: >> While in SNK_READY state, the explicit_contract seems to be >> set to true irrespective of whether an explicit contract >> was established for the current connection. TCPM also seems >> to report the pwr_opmode as TYPEC_PWR_MODE_PD always once >> the port gets into SNK_READY state. This isn't completely >> true as port gets into the SNK_READY state for non-pd >> type-c ports as well. >> >> This patch sets the explicit_contract flag only when >> the PS_READY message is received and the vbus has been >> detected by the port controller. >> >> Signed-off-by: Badhri Jagan Sridharan >> Reviewed-by: Guenter Roeck >> --- >> drivers/staging/typec/tcpm.c | 11 +++++++---- >> 1 file changed, 7 insertions(+), 4 deletions(-) > > This patch doesn't apply to the tree now that Guenter's other patches > are applied :( > > Please rebase and resend. > > thanks, > > greg k-h