Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753448AbdHQTQ5 (ORCPT ); Thu, 17 Aug 2017 15:16:57 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:39286 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdHQTQ4 (ORCPT ); Thu, 17 Aug 2017 15:16:56 -0400 Date: Thu, 17 Aug 2017 13:16:42 -0600 From: Jason Gunthorpe To: Arvind Yadav Cc: ashleydlai@gmail.com, peterhuewe@gmx.de, tpmdd@selhorst.net, jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, tpmdd-devel@lists.sourceforge.net Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id Message-ID: <20170817191642.GF24735@obsidianresearch.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 900 Lines: 24 On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote: > vio_device_id are not supposed to change at runtime. All functions > working with vio_device_id provided by work with > const vio_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Reviewed-by: Jason Gunthorpe > drivers/char/tpm/tpm_ibmvtpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c > index f01d083..d2ce46b 100644 > +++ b/drivers/char/tpm/tpm_ibmvtpm.c > @@ -32,7 +32,7 @@ > > static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm"; > > -static struct vio_device_id tpm_ibmvtpm_device_table[] = { > +static const struct vio_device_id tpm_ibmvtpm_device_table[] = { > { "IBM,vtpm", "IBM,vtpm"}, > { "", "" } > };