Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753442AbdHQVTz (ORCPT ); Thu, 17 Aug 2017 17:19:55 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:38784 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbdHQVTy (ORCPT ); Thu, 17 Aug 2017 17:19:54 -0400 Date: Thu, 17 Aug 2017 16:19:51 -0500 From: Rob Herring To: Ryder Lee Cc: Mark Brown , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, Garlic Tseng Subject: Re: [PATCH] ASoC: mediatek: Correct the interrupt property Message-ID: <20170817211951.27ozvzb62luwczan@rob-hp-laptop> References: <43a7fb98e7252d0b7b73cdabf1eedd0bf896d68c.1502784169.git.ryder.lee@mediatek.com> <20170815115309.glj52jx3kpq4jxq3@sirena.org.uk> <1502805100.25910.8.camel@mtkswgap22> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502805100.25910.8.camel@mtkswgap22> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1228 Lines: 29 On Tue, Aug 15, 2017 at 09:51:40PM +0800, Ryder Lee wrote: > On Tue, 2017-08-15 at 12:53 +0100, Mark Brown wrote: > > On Tue, Aug 15, 2017 at 04:07:02PM +0800, Ryder Lee wrote: > > > > > This patch update interrupt property since we only use ASYS IRQ > > > in the driver, and this may confuse people. > > > > > - interrupts = , > > > - ; > > > + interrupts = ; > > > > What harm does having the extra information in the bindings do? If it's > > possible there might be a use for the extra interrupt it seems better to > > have people describe it. Agreed. It should describe interrupts the h/w has, not what the driver (currently) uses. > > Yes you're right. The current driver get IRQ number by index "0" but > actually it should be "1" (GIC 132). Perhaps we can switch to use the > platform_get_irq_byname() and add interrupt-name in DT so that binding > can be agnostic of the IRQ order. The binding is wrong already in that it says a single interrrupt. The example has 2 though. Add the 2nd interrupt and define the order such that you don't break the current driver. Probably that means ASYS is first. Rob