Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753759AbdHQVli (ORCPT ); Thu, 17 Aug 2017 17:41:38 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:32820 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbdHQVle (ORCPT ); Thu, 17 Aug 2017 17:41:34 -0400 Date: Thu, 17 Aug 2017 16:41:31 -0500 From: Rob Herring To: Hans de Goede Cc: Wolfram Sang , Guenter Roeck , Heikki Krogerus , Sebastian Reichel , Darren Hart , Andy Shevchenko , Greg Kroah-Hartman , Liam Breck , Tony Lindgren , linux-i2c@vger.kernel.org, linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Frank Rowand , devicetree@vger.kernel.org, "Yueyao (Nathan) Zhu" Subject: Re: [PATCH v2 04/14] staging: typec: fusb302: Get max snk mv/ma/mw from device-properties Message-ID: <20170817214131.63vetzuove7dz5pi@rob-hp-laptop> References: <20170815200502.17339-1-hdegoede@redhat.com> <20170815200502.17339-5-hdegoede@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170815200502.17339-5-hdegoede@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2619 Lines: 70 On Tue, Aug 15, 2017 at 10:04:52PM +0200, Hans de Goede wrote: > This is board specific info so it should come from board config, such > as devicetree. > > I've chosen to prefix these with "fcs," treating them as fusb302 driver > specific for now. We may want to revisit this and replace these with > properties which are part of a (to be written) generic type-c controller > devicetree binding. > > Since this commit adds new dt-properties it also adds devicetree-bindings > documentation (which so far was absent for the fusb302 driver). > > Cc: Rob Herring > Cc: Frank Rowand > Cc: devicetree@vger.kernel.org > Cc: "Yueyao (Nathan) Zhu" > Signed-off-by: Hans de Goede > --- > Changes in v2: > -Use micro... instead of mili... > -Add devicetree bindings documentation > --- > .../devicetree/bindings/usb/fcs,fusb302.txt | 29 ++++++++++++++++++++++ > drivers/staging/typec/fusb302/TODO | 4 +++ > drivers/staging/typec/fusb302/fusb302.c | 18 +++++++++++++- > 3 files changed, 50 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/usb/fcs,fusb302.txt > > diff --git a/Documentation/devicetree/bindings/usb/fcs,fusb302.txt b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > new file mode 100644 > index 0000000..ffc6c87 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/fcs,fusb302.txt > @@ -0,0 +1,29 @@ > +Fairchild FUSB302 Type-C Port controllers > + > +Required properties : > +- compatible : "fcs,fusb302" > +- reg : I2C slave address > +- interrupts : Interrupt specifier > + > +Optional properties : > +- fcs,max-snk-microvolt : Maximum voltage to negotiate when configured as sink > +- fcs,max-snk-microamp : Maximum current to negotiate when configured as sink > +- fcs,max-snk-microwatt : Maximum power to negotiate when configured as sink > + If this is less then max-snk-microvolt * > + max-snk-microamp then the configured current will > + be clamped. > +- fcs,operating-snk-microwatt : Might as well spell out sink. Otherwise, Acked-by: Rob Herring > + Minimum amount of power accepted from a sink > + when negotiating > + > +Example: > + > +fusb302: typec-portc@54 { > + compatible = "fcs,fusb302"; > + reg = <0x54>; > + interrupt-parent = <&nmi_intc>; > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > + fcs,max-snk-microvolt = <12000000>; > + fcs,max-snk-microamp = <3000000>; > + fcs,max-snk-microwatt = <36000000>; > +};