Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754108AbdHQWJq (ORCPT ); Thu, 17 Aug 2017 18:09:46 -0400 Received: from mail-lf0-f66.google.com ([209.85.215.66]:32958 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753005AbdHQWJn (ORCPT ); Thu, 17 Aug 2017 18:09:43 -0400 Subject: Re: [PATCH 5/6] gpu: host1x: Add Tegra186 support To: Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com, robh+dt@kernel.org, mark.rutland@arm.com Cc: amerilainen@nvidia.com, dnibade@nvidia.com, sgurrappadi@nvidia.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170817185413.6324-1-mperttunen@nvidia.com> <20170817185413.6324-6-mperttunen@nvidia.com> From: Dmitry Osipenko Message-ID: <0c2035b6-456a-22a7-0a4a-1d5bf3081927@gmail.com> Date: Fri, 18 Aug 2017 01:09:39 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170817185413.6324-6-mperttunen@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 19 On 17.08.2017 21:54, Mikko Perttunen wrote: > Add support for the implementation of Host1x present on the Tegra186. > The register space has been shuffled around a little bit, requiring > addition of some chip-specific code sections. Tegra186 also adds > several new features, most importantly the hypervisor, but those are > not yet supported with this commit. > > Signed-off-by: Mikko Perttunen > --- I haven't reviewed Tegra186-specific code since I'm not familiar with that platform. Code movement related to pre-Tegra186 looks fine, no regressions spotted on Tegra20. Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko -- Dmitry