Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932106AbdHRD1r (ORCPT ); Thu, 17 Aug 2017 23:27:47 -0400 Received: from mga06.intel.com ([134.134.136.31]:56267 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753775AbdHRD1q (ORCPT ); Thu, 17 Aug 2017 23:27:46 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,391,1498546800"; d="scan'208";a="1163843289" Date: Fri, 18 Aug 2017 11:20:34 +0800 From: Wu Hao To: Moritz Fischer Cc: Alan Tull , linux-fpga@vger.kernel.org, Linux Kernel Mailing List , linux-api@vger.kernel.org, "Kang, Luwei" , "Zhang, Yi Z" , Tim Whisonant , Enno Luebbers , Shiva Rao , Christopher Rauer , Xiao Guangrong Subject: Re: [PATCH v2 20/22] fpga: intel: afu add FPGA_GET_API_VERSION/CHECK_EXTENSION ioctls support Message-ID: <20170818032034.GB25457@hao-dev> References: <1498441938-14046-1-git-send-email-hao.wu@intel.com> <1498441938-14046-21-git-send-email-hao.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2660 Lines: 75 On Thu, Aug 17, 2017 at 12:12:00PM -0700, Moritz Fischer wrote: > Hi, > > On Sun, Jun 25, 2017 at 6:52 PM, Wu Hao wrote: > > FPGA_GET_API_VERSION and FPGA_CHECK_EXTENSION ioctls are common ones which > > need to be supported by all feature devices drivers including FME and AFU. > > This patch implements above 2 ioctls in Intel FPGA Accelerated Function > > Unit (AFU) driver. > > > > Signed-off-by: Tim Whisonant > > Signed-off-by: Enno Luebbers > > Signed-off-by: Shiva Rao > > Signed-off-by: Christopher Rauer > > Signed-off-by: Xiao Guangrong > > Signed-off-by: Wu Hao > > --- > > v2: rebased > > --- > > drivers/fpga/intel-afu-main.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/fpga/intel-afu-main.c b/drivers/fpga/intel-afu-main.c > > index 2a17cde..22f77f2 100644 > > --- a/drivers/fpga/intel-afu-main.c > > +++ b/drivers/fpga/intel-afu-main.c > > @@ -122,6 +122,13 @@ static int afu_release(struct inode *inode, struct file *filp) > > return 0; > > } > > > > +static long afu_ioctl_check_extension(struct feature_platform_data *pdata, > > + unsigned long arg) > > +{ > > + /* No extension support for now */ > > Do you maybe make that an -ENOTSUPP or -EINVAL then? Hi Moritz User will use this ioctl to check if extension X is supported. It always returns 0 means any extension indicated by the arg, is not supported. I think we don't have to return an -ENOTSUPP or -EINVAL here, which may confuse the enduser. : ) Thanks Hao > > + return 0; > > +} > > + > > static long afu_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > > { > > struct platform_device *pdev = filp->private_data; > > @@ -132,6 +139,10 @@ static long afu_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > > dev_dbg(&pdev->dev, "%s cmd 0x%x\n", __func__, cmd); > > > > switch (cmd) { > > + case FPGA_GET_API_VERSION: > > + return FPGA_API_VERSION; > > + case FPGA_CHECK_EXTENSION: > > + return afu_ioctl_check_extension(pdata, arg); > > default: > > /* > > * Let sub-feature's ioctl function to handle the cmd > > -- > > 1.8.3.1 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-fpga" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Thanks, > > Moritz