Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751740AbdHRIcK (ORCPT ); Fri, 18 Aug 2017 04:32:10 -0400 Received: from mail-ua0-f181.google.com ([209.85.217.181]:38289 "EHLO mail-ua0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750709AbdHRIcI (ORCPT ); Fri, 18 Aug 2017 04:32:08 -0400 MIME-Version: 1.0 In-Reply-To: <87lgmixck8.fsf@hermes> References: <20170728105640.16268-1-lhenriques@suse.com> <87pobuz4s2.fsf@hermes> <87lgmixck8.fsf@hermes> From: Ilya Dryomov Date: Fri, 18 Aug 2017 10:32:06 +0200 Message-ID: Subject: Re: [PATCH] ceph: check negative offsets on ceph_llseek() To: Luis Henriques Cc: "Yan, Zheng" , Sage Weil , Ceph Development , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1310 Lines: 43 On Thu, Aug 17, 2017 at 8:40 PM, Luis Henriques wrote: > Ilya Dryomov writes: > >> On Thu, Aug 17, 2017 at 3:45 PM, Luis Henriques wrote: >>> Luis Henriques writes: >>> >>>> When a user requests SEEK_HOLE or SEEK_DATA with a negative offset >>>> ceph_llseek should return -ENXIO. Currently -EINVAL is being returned for >>>> SEEK_DATA and 0 for SEEK_HOLE. >>> >>> Ping >>> >>> This patch should make xfstest generic/448 happy. >> >> It should or it does? ;) >> > > Heh, it *does* make generic/448 happy. > >> >> I saw generic/448 failures on ext4 with Darrick's recent test >>change, >> haven't tried ceph yet. > > The generic/448 test currently fails with the error codes described in > the commit log. I didn't found it useful to include in the commit > log, but here's the full test output: > > File system supports the default behavior. > File system does not support unwritten extents. > File system magic#: 0xc36400 > Allocation size: 4194304 > 18. Test file with negative SEEK_{HOLE,DATA} offsets > 18.01 SEEK_HOLE expected -1 or -1, got 0. FAIL > 18.02 SEEK_DATA expected -1 with errno -6, got -22. FAIL > > seek sanity check failed! Applied. Thanks, Ilya