Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750987AbdHRLU3 (ORCPT ); Fri, 18 Aug 2017 07:20:29 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:34552 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdHRLU2 (ORCPT ); Fri, 18 Aug 2017 07:20:28 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 18 Aug 2017 16:50:27 +0530 From: kgunda@codeaurora.org To: Shawn Guo Cc: gregkh@linuxfoundation.org, sboyd@codeaurora.org, Abhijeet Dharmapurikar , David Collins , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5 In-Reply-To: <1ce6e8a0816d6d9b0ade86d3592b4dca@codeaurora.org> References: <1501225847-27807-1-git-send-email-kgunda@codeaurora.org> <1501225847-27807-12-git-send-email-kgunda@codeaurora.org> <20170817074150.GA17549@dragon> <3d9ed27c23523965dae6706ff007f1b1@codeaurora.org> <20170817122816.GB17549@dragon> <1ce6e8a0816d6d9b0ade86d3592b4dca@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2641 Lines: 64 On 2017-08-18 16:43, kgunda@codeaurora.org wrote: > On 2017-08-17 17:58, Shawn Guo wrote: >> On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgunda@codeaurora.org wrote: >>> The intention of this check is to avoid the access to the >>> peripherals those are >>> not owned by the current EE (APSS) and it is expected to return a >>> failure if the >>> peripheral that is not owned by the current EE is trying to be >>> accessed. >> >> Thanks for the background of this check. >> >>> Looks like you trying to access the GPIOs 0xc000 and 0xc100, >>> which are owned by modem subsystem but not the APSS. That is why you >>> seeing the failure for that. >>> Please change the ownership of those GPIOs to APSS (id '0') if you >>> are working on a non-modem device (APQ). >> >> Yes, it's device apq8016-sbc, and the error message is like below. >> >> [ 1.317186] spmi spmi-0: PMIC arbiter version v2 (0x20010000) >> [ 1.324784] spmi spmi-0: failed to xlate sid = 0x0, periph = 0xc0, >> irq = 0: ee=0 but owner=2 >> [ 1.329430] spmi spmi-0: failed to xlate sid = 0x0, periph = 0xc0, >> irq = 0: ee=0 but owner=2 >> [ 1.337626] qcom-spmi-gpio: probe of >> 200f000.spmi:pm8916@0:gpios@c000 failed with error -22 >> >> I see that 'qcom,ee' property of spmi_bus is already <0>. Is that >> what >> you mean by ownership of those GPIOs? >> I do not mean that. The SPMI arbiter ownership register is programmed by the boot-loader, where the actual ownership is set. The same is shown in the above logs as owner = 2. >> The pm8916_gpio is working fine on apq8016-sbc device with the current >> mainline kernel. It's not good to break the existing device without >> a very good. IMO, we should get this fixed before the patch is >> merged. >> >> Shawn >> -- > > From the logs the ownership for these GPIOs is not assigned to the > application processor but to another master. Considering this is a > (apq8016-sbc) APSS only platform ideally the fix for this would be to > update the ownership table in the boot loader. The other option would > be to make the existing ownership check in SW optional for a platform > via DT. I will push a patch shortly for this. Could you please give > that a try. > > Thanks, > Kiran >> To unsubscribe from this list: send the line "unsubscribe >> linux-arm-msm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe > linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html