Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750993AbdHRLnk (ORCPT ); Fri, 18 Aug 2017 07:43:40 -0400 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:57141 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbdHRLni (ORCPT ); Fri, 18 Aug 2017 07:43:38 -0400 Subject: Re: [PATCH] pci: dwc: Clear MSI interrupt status after it is handled To: Faiz Abbas , , CC: , , References: <1502364295-3786-1-git-send-email-faiz_abbas@ti.com> From: Joao Pinto Message-ID: Date: Fri, 18 Aug 2017 12:43:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1502364295-3786-1-git-send-email-faiz_abbas@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: pt-PT Content-Transfer-Encoding: 8bit X-Originating-IP: [10.107.19.80] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 34 Hello, Às 12:24 PM de 8/10/2017, Faiz Abbas escreveu: > If the interrupt status is cleared before it is handled, it is possible > that another interrupt will trigger while servicing the previous one. > This is causing timeouts in some wireless lan cards which use pcie. > Therefore, clear MSI interrupt status after it gets serviced instead > of before calling generic_handler. > > Signed-off-by: Faiz Abbas > --- > drivers/pci/dwc/pcie-designware-host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/dwc/pcie-designware-host.c b/drivers/pci/dwc/pcie-designware-host.c > index 28ed32b..78b2584 100644 > --- a/drivers/pci/dwc/pcie-designware-host.c > +++ b/drivers/pci/dwc/pcie-designware-host.c > @@ -71,9 +71,9 @@ irqreturn_t dw_handle_msi_irq(struct pcie_port *pp) > while ((pos = find_next_bit((unsigned long *) &val, 32, > pos)) != 32) { > irq = irq_find_mapping(pp->irq_domain, i * 32 + pos); > + generic_handle_irq(irq); > dw_pcie_wr_own_conf(pp, PCIE_MSI_INTR0_STATUS + i * 12, > 4, 1 << pos); > - generic_handle_irq(irq); > pos++; > } > } > It makes sense. Acked-By: Joao Pinto