DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0726780467
Subject: Re: [PATCH] kvm: VMX: do not use vm-exit instruction length for fast
 MMIO
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, "Michael S. Tsirkin" <mst@redhat.com>,
        stable@vger.kernel.org
References: <1502890494-35208-1-git-send-email-pbonzini@redhat.com>
 <901d4c2e-aa94-2002-babc-7f042946a327@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <3b7afdfc-d308-7645-2105-6bb339188aa6@redhat.com>
Date: Fri, 18 Aug 2017 14:35:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <901d4c2e-aa94-2002-babc-7f042946a327@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 578
Lines: 19

On 18/08/2017 13:57, David Hildenbrand wrote:
> What about a hack:
> 
> 1. clear instruction length when entering
> 2. check if instruction length is set when trying to forward the RIP
> 2a. if set, use it
> 2b. if not set, compute it

It's undefined, so we don't know that the instruction length remains
zero (also, on older processors and possibly some nested setups the
field is read-only).

Testing the hypervisor bit is the first line of action.

Paolo

> this at least should give full speedup in existing setups. Not 99%
> architecturally correct but might just work.
>