DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7DA0880469
Subject: Re: [PATCH 2/3] KVM: x86: Avoid guest page table walk when
 gpa_available is set
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        David Hildenbrand <david@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        wanpeng.li@hotmail.com, Brijesh Singh <brijesh.singh@amd.com>
References: <1502987818-24065-1-git-send-email-pbonzini@redhat.com>
 <1502987818-24065-3-git-send-email-pbonzini@redhat.com>
 <97f78603-3007-2418-653a-58a0d33a0523@redhat.com>
 <20170818123649.GB20100@flask>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <661ca6b5-bfb4-5377-d537-fb058d86ca0c@redhat.com>
Date: Fri, 18 Aug 2017 14:37:51 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170818123649.GB20100@flask>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 598
Lines: 19

On 18/08/2017 14:36, Radim Krčmář wrote:
>>> +		gpa = vcpu->arch.gpa_val;
>>> +		ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write);
>>> +	} else {
>>> +		ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
>>>  	}
>>>  
>>> -	ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
>>> -
>>>  	if (ret < 0)
>>>  		return X86EMUL_PROPAGATE_FAULT;
>> just wondering if it makes sense to move this into the else branch (as
>> it logically only belongs to vcpu_mmio_gva_to_gpa)
>
> It does, I took the liberty to change that.

It was on purpose, but it's okay either way. :)

Paolo