Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752138AbdHRMig (ORCPT ); Fri, 18 Aug 2017 08:38:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18159 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdHRMid (ORCPT ); Fri, 18 Aug 2017 08:38:33 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 69B057E436 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=pbonzini@redhat.com Subject: Re: [PATCH 3/3] KVM: x86: fix use of L1 MMIO areas in nested guests To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , David Hildenbrand Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, wanpeng.li@hotmail.com References: <1502987818-24065-1-git-send-email-pbonzini@redhat.com> <1502987818-24065-4-git-send-email-pbonzini@redhat.com> <02b6b9d8-6a26-f050-d763-23489befbbaa@redhat.com> <20170818123550.GA20100@flask> From: Paolo Bonzini Message-ID: <2e8a771e-8e6b-5f01-7806-800e785c59be@redhat.com> Date: Fri, 18 Aug 2017 14:38:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170818123550.GA20100@flask> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 18 Aug 2017 12:38:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 511 Lines: 16 On 18/08/2017 14:35, Radim Krčmář wrote: > >>> diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h >>> @@ -90,7 +90,11 @@ static inline u32 bit(int bitno) >>> static inline void vcpu_cache_mmio_info(struct kvm_vcpu *vcpu, >>> gva_t gva, gfn_t gfn, unsigned access) >>> { >>> - vcpu->arch.mmio_gva = gva & PAGE_MASK; >>> + /* >>> + * If this is a shadow nested page table, the "GVA" is >> s/"GVA"/GVA/ ? > I prefer the former, we're talking about "gva_t gva" that isn't GVA. :) Exactly. :) Paolo