DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 854224ACA5
Date: Fri, 18 Aug 2017 14:40:47 +0200
From: Radim =?utf-8?B?S3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, wanpeng.li@hotmail.com,
        Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH 2/3] KVM: x86: Avoid guest page table walk when
 gpa_available is set
Message-ID: <20170818124047.GC20100@flask>
References: <1502987818-24065-1-git-send-email-pbonzini@redhat.com>
 <1502987818-24065-3-git-send-email-pbonzini@redhat.com>
 <97f78603-3007-2418-653a-58a0d33a0523@redhat.com>
 <20170818123649.GB20100@flask>
 <661ca6b5-bfb4-5377-d537-fb058d86ca0c@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <661ca6b5-bfb4-5377-d537-fb058d86ca0c@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 737
Lines: 20

2017-08-18 14:37+0200, Paolo Bonzini:
> On 18/08/2017 14:36, Radim Krčmář wrote:
> >>> +		gpa = vcpu->arch.gpa_val;
> >>> +		ret = vcpu_is_mmio_gpa(vcpu, addr, gpa, write);
> >>> +	} else {
> >>> +		ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
> >>>  	}
> >>>  
> >>> -	ret = vcpu_mmio_gva_to_gpa(vcpu, addr, &gpa, exception, write);
> >>> -
> >>>  	if (ret < 0)
> >>>  		return X86EMUL_PROPAGATE_FAULT;
> >> just wondering if it makes sense to move this into the else branch (as
> >> it logically only belongs to vcpu_mmio_gva_to_gpa)
> >
> > It does, I took the liberty to change that.
> 
> It was on purpose, but it's okay either way. :)

Oh, sorry, I was thinking that vcpu_is_mmio_gpa() should return bool. :)