Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751575AbdHRMqj (ORCPT ); Fri, 18 Aug 2017 08:46:39 -0400 Received: from mail-qt0-f171.google.com ([209.85.216.171]:34546 "EHLO mail-qt0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750953AbdHRMqh (ORCPT ); Fri, 18 Aug 2017 08:46:37 -0400 MIME-Version: 1.0 In-Reply-To: <20170815224250.GA28337@fury> References: <20170815224250.GA28337@fury> From: Andy Shevchenko Date: Fri, 18 Aug 2017 15:46:36 +0300 Message-ID: Subject: Re: [PATCH v2] platform/x86: ideapad-laptop: Expose conservation mode switch To: Darren Hart Cc: Hao Wei Tee , Platform Driver , "linux-kernel@vger.kernel.org" , Andy Shevchenko , Ike Panhc Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 812 Lines: 27 On Wed, Aug 16, 2017 at 1:42 AM, Darren Hart wrote: > On Mon, Aug 14, 2017 at 06:32:48PM +0300, Andy Shevchenko wrote: >> On Mon, Aug 14, 2017 at 5:17 PM, Hao Wei Tee wrote: >> > +static int method_gbmd(acpi_handle handle, unsigned long *ret) >> > +{ >> > + int val; >> > + int result = read_method_int(handle, "GBMD", &val); >> >> Reversed X-mas tree order in new code, please. > > Generally yes, but of here they are using &val in the second initializer. > > So either as is or: > > int result; > int val; > > result = read_method_int(handle, "GBMD", &val) > > I tend to accept it as is when there is a declaration order dependency like > this. There is a new version which I applied, there is no dependencies left. -- With Best Regards, Andy Shevchenko