Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753016AbdHRNjC (ORCPT ); Fri, 18 Aug 2017 09:39:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:57098 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbdHRNjA (ORCPT ); Fri, 18 Aug 2017 09:39:00 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F083F22CAB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Fri, 18 Aug 2017 09:38:57 -0400 From: Steven Rostedt To: Byungchul Park Cc: peterz@infradead.org, mingo@kernel.org, joel.opensrc@gmail.com, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com Subject: Re: [PATCH v8 2/2] sched/rt: Add support for SD_PREFER_SIBLING on find_lowest_rq() Message-ID: <20170818093857.496462dd@gandalf.local.home> In-Reply-To: <1503044519-2804-3-git-send-email-byungchul.park@lge.com> References: <1503044519-2804-1-git-send-email-byungchul.park@lge.com> <1503044519-2804-3-git-send-email-byungchul.park@lge.com> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 349 Lines: 13 On Fri, 18 Aug 2017 17:21:59 +0900 Byungchul Park wrote: > It would be better to try to check other siblings first if > SD_PREFER_SIBLING is flaged when pushing tasks - migration. > > Signed-off-by: Byungchul Park Looks good. Reviewed-by: Steven Rostedt (VMware) -- Steve