Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432AbdHROXV (ORCPT ); Fri, 18 Aug 2017 10:23:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:36770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbdHROXR (ORCPT ); Fri, 18 Aug 2017 10:23:17 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56D1F22C98 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=acme@kernel.org Date: Fri, 18 Aug 2017 11:23:14 -0300 From: Arnaldo Carvalho de Melo To: Taeung Song Cc: linux-kernel@vger.kernel.org, taeung@kosslab.kr, Namhyung Kim , Milian Wolff , Jiri Olsa Subject: Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view Message-ID: <20170818142314.GJ10891@kernel.org> References: <1503046028-5691-1-git-send-email-treeze.taeung@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503046028-5691-1-git-send-email-treeze.taeung@gmail.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1331 Lines: 34 Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: > With a existing 't' hotkey, support the three view based on percent, > total period and number of samples on the annotate TUI browser, > circulating them like below: > > Percent -> Period -> Samples -> Percent ... > > Suggested-by: Namhyung Kim > Cc: Milian Wolff > Cc: Jiri Olsa > Signed-off-by: Taeung Song > --- Ok, here I removed this part, that is not documented in the patch nor in the 'h' help screen, if you think it should be considered, please resubmit it with a proper explanation: diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index e82e6c5df83b..ba0aee576a2b 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -921,12 +921,6 @@ static int annotate_browser__run(struct annotate_browser *browser, annotate_browser__opts.show_total_period = true; annotate_browser__update_addr_width(browser); continue; - case 'e': - annotate_browser__opts.show_total_period = false; - annotate_browser__opts.show_nr_samples = - !annotate_browser__opts.show_nr_samples; - annotate_browser__update_addr_width(browser); - continue; case K_LEFT: case K_ESC: case 'q':