Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751114AbdHROg3 (ORCPT ); Fri, 18 Aug 2017 10:36:29 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:38630 "EHLO mail-io0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750949AbdHROg2 (ORCPT ); Fri, 18 Aug 2017 10:36:28 -0400 MIME-Version: 1.0 In-Reply-To: <1501767444-27873-2-git-send-email-arvind.yadav.cs@gmail.com> References: <1501767444-27873-1-git-send-email-arvind.yadav.cs@gmail.com> <1501767444-27873-2-git-send-email-arvind.yadav.cs@gmail.com> From: Ard Biesheuvel Date: Fri, 18 Aug 2017 15:36:27 +0100 Message-ID: Subject: Re: [PATCH 1/3] firmware: dcdbas: constify attribute_group structures. To: Arvind Yadav Cc: Douglas_Warzecha@dell.com, Matt Fleming , Ingo Molnar , "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 989 Lines: 25 On 3 August 2017 at 14:37, Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by work with > const attribute_group. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav > --- > drivers/firmware/dcdbas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c > index 2fe1a13..c16600f 100644 > --- a/drivers/firmware/dcdbas.c > +++ b/drivers/firmware/dcdbas.c > @@ -534,7 +534,7 @@ static int dcdbas_reboot_notify(struct notifier_block *nb, unsigned long code, > NULL > }; > > -static struct attribute_group dcdbas_attr_group = { > +static const struct attribute_group dcdbas_attr_group = { > .attrs = dcdbas_dev_attrs, > .bin_attrs = dcdbas_bin_attrs, > }; If Douglas doesn't mind, I will take this trough the EFI tree