MIME-Version: 1.0
In-Reply-To: <20170818152830.k5mvkgnunlzr2enk@art_vandelay>
References: <1502996404-15143-1-git-send-email-john.stultz@linaro.org> <20170818152830.k5mvkgnunlzr2enk@art_vandelay>
From: John Stultz <john.stultz@linaro.org>
Date: Fri, 18 Aug 2017 10:44:52 -0700
Message-ID: <CALAqxLVN2HbSft6XsgOyWc4xMEtsMENFKAHMvL-kp5a+tp-4xQ@mail.gmail.com>
Subject: Re: [RESEND][PATCH v4] drm: kirin: Add mode_valid logic to avoid mode
 clocks we can't generate
To: Sean Paul <seanpaul@chromium.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
        Daniel Vetter <daniel.vetter@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>,
        Xinliang Liu <xinliang.liu@linaro.org>,
        Xinliang Liu <z.liuxinliang@hisilicon.com>,
        Rongrong Zou <zourongrong@gmail.com>,
        Xinwei Kong <kong.kongxinwei@hisilicon.com>,
        Chen Feng <puck.chen@hisilicon.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Archit Taneja <architt@codeaurora.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1689
Lines: 40

On Fri, Aug 18, 2017 at 8:28 AM, Sean Paul <seanpaul@chromium.org> wrote:
> On Thu, Aug 17, 2017 at 12:00:04PM -0700, John Stultz wrote:
>> Currently the hikey dsi logic cannot generate accurate byte
>> clocks values for all pixel clock values. Thus if a mode clock
>> is selected that cannot match the calculated byte clock, the
>> device will boot with a blank screen.
>>
>> This patch uses the new mode_valid callback (many thanks to
>> Jose Abreu for upstreaming it!) to ensure we don't select
>> modes we cannot generate.
>>
>> Also, since the ade crtc code will adjust the mode in mode_set,
>> this patch also adds a mode_fixup callback which we use to make
>> sure we are validating the mode clock that will eventually be
>> used.
>>
>> Cc: Daniel Vetter <daniel.vetter@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Sean Paul <seanpaul@chromium.org>
>> Cc: David Airlie <airlied@linux.ie>
>> Cc: Rob Clark <robdclark@gmail.com>
>> Cc: Xinliang Liu <xinliang.liu@linaro.org>
>> Cc: Xinliang Liu <z.liuxinliang@hisilicon.com>
>> Cc: Rongrong Zou <zourongrong@gmail.com>
>> Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
>> Cc: Chen Feng <puck.chen@hisilicon.com>
>> Cc: Jose Abreu <Jose.Abreu@synopsys.com>
>> Cc: Archit Taneja <architt@codeaurora.org>
>> Cc: dri-devel@lists.freedesktop.org
>> Signed-off-by: John Stultz <john.stultz@linaro.org>
>
> Hi John,
> Thanks for continuing to send new versions for this patch. It looks good to me
> (there's a small spelling mistake in a comment below that perhaps can be fixed
> when applied, no biggy).
>
> Reviewed-by: Sean Paul <seanpaul@chromium.org>

Thanks so much for the review! I really appreciate it!
-john