Date: Fri, 18 Aug 2017 20:38:33 +0200
From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Francis Deslauriers <francis.deslauriers@efficios.com>,
        mathieu.desnoyers@efficios.com, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>,
        "David S . Miller" <davem@davemloft.net>, linux-kernel@vger.kernel.org,
        Yoshinori Sato <ysato@users.sourceforge.jp>,
        Chris Zankel <chris@zankel.net>, Max Filippov <jcmvbkbc@gmail.com>,
        Mikael Starvik <starvik@axis.com>, Jesper Nilsson <jespern@axis.com>,
        linux-cris-kernel@axis.com, linux-arch@vger.kernel.org
Subject: Re: [PATCH -tip v9 3/5] cris: mark _stext and _end as char-arrays,
 not single char
Message-ID: <20170818183833.GG16480@axis.com>
References: <150172762859.27216.16741726568669538542.stgit@devbox>
 <150172782555.27216.2805751327900543374.stgit@devbox>
 <20170816200133.1abbd36d5b5621f6f4b7f639@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170816200133.1abbd36d5b5621f6f4b7f639@kernel.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1519
Lines: 45

On Wed, Aug 16, 2017 at 08:01:33PM +0900, Masami Hiramatsu wrote:
> On Thu,  3 Aug 2017 11:37:15 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
> 
> > diff --git a/arch/cris/kernel/traps.c b/arch/cris/kernel/traps.c
> > index a01636a12a6e..d98131c45bb5 100644
> > --- a/arch/cris/kernel/traps.c
> > +++ b/arch/cris/kernel/traps.c
> > @@ -42,7 +42,7 @@ void (*nmi_handler)(struct pt_regs *);
> >  void show_trace(unsigned long *stack)
> >  {
> >  	unsigned long addr, module_start, module_end;
> > -	extern char _stext, _etext;
> > +	extern char _stext[], _etext[];
> >  	int i;
> >  
> >  	pr_err("\nCall Trace: ");
> > @@ -69,8 +69,8 @@ void show_trace(unsigned long *stack)
> >  		 * down the cause of the crash will be able to figure
> >  		 * out the call path that was taken.
> >  		 */
> > -		if (((addr >= (unsigned long)&_stext) &&
> > -		     (addr <= (unsigned long)&_etext)) ||
> > +		if (((addr >= (unsigned long)_stext) &&
> > +		     (addr <= (unsigned long)_etext)) ||
> >  		    ((addr >= module_start) && (addr <= module_end))) {
> 
> BTW, I would like to ask cris people, this seems to check over 1 byte,
> since _etext and module_end will be placed at the next byte of the real
> address area.
> As same as other arch, Should it be 
> 
> (addr < (unsigned long)_etext)
> 
> or are there any other reason?

As far as I can tell, this is non-intentional.

> Thank you,

> Masami Hiramatsu <mhiramat@kernel.org>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@axis.com