Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbdHRUDD (ORCPT ); Fri, 18 Aug 2017 16:03:03 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:58219 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbdHRUDB (ORCPT ); Fri, 18 Aug 2017 16:03:01 -0400 Message-ID: <1503086568.3688.28.camel@decadent.org.uk> Subject: Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume From: Ben Hutchings To: Sandeep Singh , Shyam Sundar S K Cc: stable@vger.kernel.org, Nehal Shah , Felipe Balbi , Greg Kroah-Hartman , LKML Date: Fri, 18 Aug 2017 21:02:48 +0100 In-Reply-To: <20170815011944.259471330@linuxfoundation.org> References: <20170815011942.395714306@linuxfoundation.org> <20170815011944.259471330@linuxfoundation.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-KN56DdXV7MCQ1A0azLE0" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 82.70.136.246 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2468 Lines: 70 --=-KN56DdXV7MCQ1A0azLE0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote: > 4.12-stable review patch.=C2=A0=C2=A0If anyone has any objections, please= let me know. >=20 > ------------------ >=20 > From: Sandeep Singh >=20 > commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream. [...] > --- a/drivers/usb/host/pci-quirks.c > +++ b/drivers/usb/host/pci-quirks.c > @@ -98,6 +98,7 @@ enum amd_chipset_gen { > =C2=A0 AMD_CHIPSET_HUDSON2, > =C2=A0 AMD_CHIPSET_BOLTON, > =C2=A0 AMD_CHIPSET_YANGTZE, > + AMD_CHIPSET_TAISHAN, > =C2=A0 AMD_CHIPSET_UNKNOWN, > =C2=A0}; > =C2=A0 > @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru > =C2=A0 pinfo->sb_type.gen =3D AMD_CHIPSET_SB700; > =C2=A0 else if (rev >=3D 0x40 && rev <=3D 0x4f) > =C2=A0 pinfo->sb_type.gen =3D AMD_CHIPSET_SB800; > + } > + pinfo->smbus_dev =3D pci_get_device(PCI_VENDOR_ID_AMD, > + =C2=A0=C2=A00x145c, NULL); > + if (pinfo->smbus_dev) { > + pinfo->sb_type.gen =3D AMD_CHIPSET_TAISHAN; > =C2=A0 } else { > =C2=A0 pinfo->smbus_dev =3D pci_get_device(PCI_VENDOR_ID_AMD, > =C2=A0 PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL); [...] This causes pinfo->smbus_dev to be wrongly set to NULL on systems with the ATI chipset that this function checks for first. Ben. --=20 Ben Hutchings Reality is just a crutch for people who can't handle science fiction. --=-KN56DdXV7MCQ1A0azLE0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlmXR+gACgkQ57/I7JWG EQlpkQ/9HGQTwSHRj75qIQM2nIwu2kp0ZR6pPqmo5ihwVBukxlXERMjIfmfNfVK4 9OZ9L/L9NjsgEDB/QAaN7R+s+vjls4ZDSAlMb1KZTLJazV4PCZ7wJ97ju/du1U8c ybM+Ho0TQ6tlejU8QASPg8uOZwBupyxu+4il96vqsQOkpuV62Dy+w33/3nk4stZA E4Pjb/IFwPgfQUUtBo+jFSZfYffjGldoF+NMY7hLeia5CpANEtqjyaN3NLC1GBrO Si4y12p758m/j+NDOogN2t5zbShuqqcRb9lYGUsMKuEqV3AE3K8hUvK5knJ6c9vD sMe3b5ida/YyoVLNN09qfflIlcXgy12yxWOU5IaXRqeiVB9NWlW6+9hGFtIfymYl GVCGOpMNceemcVlHgh/wIwMuwgNdylJdw+rn8QzTLKgvP8axxRHU/fDfbLRrkcoJ cAs7yRCIJ0I9rR41W0/LpQwXAmy8yZ/3yyTlHlOegdf/oLTzjvwOJJWfIrOTlTJg P4c3+K6w31fcufGaTlxG8tWkvbiSnyqWUs0sVIieQgjxr+57YttwHDWzJ6x1UBsM 6aFcjNbzufNDSjjtU+PqRIulhp0LpYxh96epxlAAcKrUnY12Kcn6a3k61V1ZtGY3 +feUJH5XaOWwqLMv0yllRoMN6atp1PLGkStDJf8QlEO0c5umnEA= =4KJb -----END PGP SIGNATURE----- --=-KN56DdXV7MCQ1A0azLE0--