Message-ID: <1503086826.3688.30.camel@decadent.org.uk>
Subject: Re: [PATCH 4.12 55/65] pinctrl: sunxi: add a missing function of
 A10/A20 pinctrl driver
From: Ben Hutchings <ben@decadent.org.uk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org, Icenowy Zheng <icenowy@aosc.io>,
        Chen-Yu Tsai <wens@csie.org>, Linus Walleij <linus.walleij@linaro.org>
Date: Fri, 18 Aug 2017 21:07:06 +0100
In-Reply-To: <20170815011944.581180081@linuxfoundation.org>
References: <20170815011942.395714306@linuxfoundation.org>
         <20170815011944.581180081@linuxfoundation.org>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-G+fUMzVubLSL8k4WuG0o"
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3213
Lines: 83


--=-G+fUMzVubLSL8k4WuG0o
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote:
> 4.12-stable review patch.=C2=A0=C2=A0If anyone has any objections, please=
 let me know.
>=20
> ------------------
>=20
> From: Icenowy Zheng <icenowy@aosc.io>
>=20
> commit d81ece747d8727bb8b1cfc9a20dbe62f09a4e35a upstream.
>=20
> The PH16 pin has a function with mux id 0x5, which is the DET pin of the
> "sim" (smart card reader) IP block.
>=20
> This function is missing in old versions of A10/A20 SoCs' datasheets and
> user manuals, so it's also missing in the old drivers. The newest A10
> Datasheet V1.70 and A20 Datasheet V1.41 contain this pin function, and
> it's discovered during implementing R40 pinctrl driver.
>=20
> Add it to the driver. As we now merged A20 pinctrl driver to the A10
> one, we need to only fix the A10 driver now.

That happened after 4.12, so I think for stable the same change should
be applied in drivers/pinctrl/sunxi/pinctrl-sun7i-a20.c.

Ben.

> Fixes: f2821b1ca3a2 ("pinctrl: sunxi: Move Allwinner A10 pinctrl
> driver to a driver of its own")
>=20
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>=20
> ---
> =C2=A0drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c |=C2=A0=C2=A0=C2=A0=C2=A0=
1 +
> =C2=A01 file changed, 1 insertion(+)
>=20
> --- a/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sun4i-a10.c
> @@ -811,6 +811,7 @@ static const struct sunxi_desc_pin sun4i
> =C2=A0		=C2=A0=C2=A0SUNXI_FUNCTION(0x2, "lcd1"),		/* D16 */
> =C2=A0		=C2=A0=C2=A0SUNXI_FUNCTION(0x3, "pata"),		/* ATAD12 */
> =C2=A0		=C2=A0=C2=A0SUNXI_FUNCTION(0x4, "keypad"),	/* IN6 */
> +		=C2=A0=C2=A0SUNXI_FUNCTION(0x5, "sim"),		/* DET */
> =C2=A0		=C2=A0=C2=A0SUNXI_FUNCTION_IRQ(0x6, 16),		/* EINT16 */
> =C2=A0		=C2=A0=C2=A0SUNXI_FUNCTION(0x7, "csi1")),		/* D16 */
> =C2=A0	SUNXI_PIN(SUNXI_PINCTRL_PIN(H, 17),
>=20
>=20
--=20
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.


--=-G+fUMzVubLSL8k4WuG0o
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEErCspvTSmr92z9o8157/I7JWGEQkFAlmXSOoACgkQ57/I7JWG
EQn2NRAAr6RK1wVj7r+RRp2AZNPZiX1wwh+Iq4Z9TlXjyqR3NhJq+xTU7UW2Dgoa
gFkNEAYMnc6BgzwB5R1KM+tDz6NhXWQagGdyef8amiRbooD8AFPZV1mCxqYKV4Wy
O+rf+DtyGyp7xcwD+YP9ToxrPS2jGJAxEiq8a48r3FKpTKr+BQx33nczg2UFYKzQ
eNTJbJaDvsZ7tExmBqFpQ87tAuNs3/dDElFoCOHetQnxIPqSkGaX/WeNoI/86b6Q
8MnWC3HY1P/OleRBACvywVyVgxOJA4b0ng0UWbSS0yTVmJkH74mjWeqG9Pi7Dy48
63pU/fdmDfEmHf1n0Rv3Zz+gbNXQFd9lLWKtrB0oDNt9s/JAFwt0srpQctWKSxgX
uE/AKJCzE5Bc9dujgSMxR8WEhxCqCgsdEDz+F5ERNP4yDyq8kI45lWg/vh01oNas
alDTG+jMlQpPaYD+t0t81etk+XZo9X9bX5g8j9cPoGN73vO9+7fNALfGklty3DHY
R3VSN2GoTttrhIiGQ3neyXbetTIaTifNXm/J7a3/zlrve3l7pEYhXoGu/8ke0CUK
i+qFzmL2RSSIhoFpq3BZcHGYUQLmQ886LVSkXB+nKpCe1qViergVO35HzZ4jg9Ux
CHHCR8Ikgu0Ki0h3ZnJrO4AsvJP0vxJTrkBUL9dBqRNAEpLrm+s=
=2ysn
-----END PGP SIGNATURE-----

--=-G+fUMzVubLSL8k4WuG0o--