Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752547AbdHRVy4 (ORCPT ); Fri, 18 Aug 2017 17:54:56 -0400 Received: from mail-lf0-f50.google.com ([209.85.215.50]:34304 "EHLO mail-lf0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752066AbdHRVyy (ORCPT ); Fri, 18 Aug 2017 17:54:54 -0400 Subject: Re: [PATCH 3/4] gpu: host1x: Improve debug disassembly formatting To: Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170818161553.27597-1-mperttunen@nvidia.com> <20170818161553.27597-4-mperttunen@nvidia.com> From: Dmitry Osipenko Message-ID: <0864cb4f-93b4-522f-bf0e-27be75a5b1d5@gmail.com> Date: Sat, 19 Aug 2017 00:54:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20170818161553.27597-4-mperttunen@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 598 Lines: 18 On 18.08.2017 19:15, Mikko Perttunen wrote: > The host1x driver prints out "disassembly" dumps of the command FIFO > and gather contents on submission timeouts. However, the output has > been quite difficult to read with unnecessary newlines and occasional > missing parentheses. > > Fix these problems by using pr_cont to remove unnecessary newlines > and by fixing other small issues. > > Signed-off-by: Mikko Perttunen > --- It's indeed a bit more readable now. Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko -- Dmitry