Date: Fri, 18 Aug 2017 15:50:55 -0700
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Sandeep Singh <Sandeep.Singh@amd.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>, stable@vger.kernel.org,
        Nehal Shah <Nehal-bakulchandra.Shah@amd.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP
 keyboard on reset after resume
Message-ID: <20170818225055.GB6159@kroah.com>
References: <20170815011942.395714306@linuxfoundation.org>
 <20170815011944.259471330@linuxfoundation.org>
 <1503086568.3688.28.camel@decadent.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1503086568.3688.28.camel@decadent.org.uk>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1540
Lines: 46

On Fri, Aug 18, 2017 at 09:02:48PM +0100, Ben Hutchings wrote:
> On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote:
> > 4.12-stable review patch.??If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Sandeep Singh <sandeep.singh@amd.com>
> > 
> > commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream.
> [...]
> > --- a/drivers/usb/host/pci-quirks.c
> > +++ b/drivers/usb/host/pci-quirks.c
> > @@ -98,6 +98,7 @@ enum amd_chipset_gen {
> > ?	AMD_CHIPSET_HUDSON2,
> > ?	AMD_CHIPSET_BOLTON,
> > ?	AMD_CHIPSET_YANGTZE,
> > +	AMD_CHIPSET_TAISHAN,
> > ?	AMD_CHIPSET_UNKNOWN,
> > ?};
> > ?
> > @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru
> > ?			pinfo->sb_type.gen = AMD_CHIPSET_SB700;
> > ?		else if (rev >= 0x40 && rev <= 0x4f)
> > ?			pinfo->sb_type.gen = AMD_CHIPSET_SB800;
> > +	}
> > +	pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> > +					??0x145c, NULL);
> > +	if (pinfo->smbus_dev) {
> > +		pinfo->sb_type.gen = AMD_CHIPSET_TAISHAN;
> > ?	} else {
> > ?		pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> > ?				PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
> [...]
> 
> This causes pinfo->smbus_dev to be wrongly set to NULL on systems with
> the ATI chipset that this function checks for first.

Ugh, for such a "simple" quirk, this has gone through so many different
iterations, all of which seem broken :(

Sandeep, can you fix this up and send a follow-on patch to us and the
linux-usb mailing list so we can get it fixed up properly?

thanks,

greg k-h