Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbdHRX6A (ORCPT ); Fri, 18 Aug 2017 19:58:00 -0400 Received: from mga11.intel.com ([192.55.52.93]:7948 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751169AbdHRX57 (ORCPT ); Fri, 18 Aug 2017 19:57:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,393,1498546800"; d="scan'208";a="142050655" From: "Dilger, Andreas" To: Greg KH CC: Cihangir Akturk , Lustre Development List , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List , "Drokin, Oleg" , "James Simmons" Subject: Re: [PATCH] staging: lustre: fix structure size for ARM OABI Thread-Topic: [PATCH] staging: lustre: fix structure size for ARM OABI Thread-Index: AQHTF3WesrETYBMJykibnOTf97pQeKKLQg6A Date: Fri, 18 Aug 2017 23:57:58 +0000 Message-ID: References: <1502894655-9731-1-git-send-email-cakturk@gmail.com> <20170817162639.GA13066@kroah.com> In-Reply-To: <20170817162639.GA13066@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.83.16] Content-Type: text/plain; charset="utf-8" Content-ID: <32E3207F15BC5946B2B485141129D67C@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id v7INw6Dh009314 Content-Length: 1069 Lines: 36 On Aug 17, 2017, at 10:26, Greg KH wrote: > > On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote: >> When building the kernel for the ARM architecture without setting >> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3 >> differs, due to different alignment requirements of OABI and EABI. >> >> Marking the anonymous union within struct lov_user_md_v3 as >> '_packed' solves this issue. Otherwise we get the following >> error: >> >> drivers/staging/lustre/lustre/lov/lov_pack.c:352:2: note: in expansion >> of macro ‘BUILD_BUG_ON’ >> BUILD_BUG_ON(sizeof(lum) != sizeof(struct lov_mds_md_v3)); >> >> Signed-off-by: Cihangir Akturk >> --- >> drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > This file is no longer in the tree :( With James' recent patch series, this has moved to include/uapi/linux/lustre/lustre_user.h Cheers, Andreas -- Andreas Dilger Lustre Principal Architect Intel Corporation