Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbdHSAF5 (ORCPT ); Fri, 18 Aug 2017 20:05:57 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33822 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751075AbdHSAFz (ORCPT ); Fri, 18 Aug 2017 20:05:55 -0400 Subject: Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different events to work parallely. To: Jonathan Cameron Cc: Martin Kepplinger , Peter Meerwald-Stadler , knaack.h@gmx.de, lars@metafoo.de, gregkh@linuxfoundation.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, amsfield22@gmail.com References: <1502750644-8854-1-git-send-email-harinath922@gmail.com> <0a512995-3fd5-e38e-73a6-417337515ce6@gmail.com> <13587F36-588D-4011-8E70-A8892F81887E@posteo.de> <9202ac3c-cc5b-2b45-ba37-d6a24364b9e6@gmail.com> <20170817154041.6292ea19@archlinux> From: Harinath Nampally Message-ID: <6473aa07-e3d6-5b2b-39d4-38456cf7b301@gmail.com> Date: Fri, 18 Aug 2017 20:05:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170817154041.6292ea19@archlinux> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 28 > This patch fixes by detaching the event related information from > chip_info struct, >>> and based on channel type and event direction the corresponding > event configuration registers >>> are picked dynamically. Hence multiple events can be handled in > read/write callbacks. >> which chip can have which event(s)? > I am planning to add 'supported events' field in > One small point. Don't put the word bugfix in the title (and fix > spelling of enable!). I know this is obviously a false restriction > on the driver, but it doesn't not work, it is just limited in features > without this. Sure, thanks for letting me know. On 08/17/2017 10:40 AM, Jonathan Cameron wrote: >>> This patch fixes by detaching the event related information from >>> chip_info struct, >>>>> and based on channel type and event direction the corresponding >>> event configuration registers >>>>> are picked dynamically. Hence multiple events can be handled in >>> read/write callbacks. >>>> which chip can have which event(s)? >>> I am planning to add 'supported events' field in > One small point. Don't put the word bugfix in the title (and fix > spelling of enable!). I know this is obviously a false restriction > on the driver, but it doesn't not work, it is just limited in features > without this.