Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbdHSAgZ (ORCPT ); Fri, 18 Aug 2017 20:36:25 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:36286 "EHLO mail-wr0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdHSAgW (ORCPT ); Fri, 18 Aug 2017 20:36:22 -0400 MIME-Version: 1.0 In-Reply-To: <20170817224845.29630-1-shuahkh@osg.samsung.com> References: <20170817224845.29630-1-shuahkh@osg.samsung.com> From: John Stultz Date: Fri, 18 Aug 2017 17:36:21 -0700 Message-ID: Subject: Re: [PATCH] selftests: timers: Fix run_destructive_tests target to handle skipped tests To: Shuah Khan Cc: Shuah Khan , Thomas Gleixner , Stephen Boyd , lkml , linux-kselftest@vger.kernel.org, Benjamin Gaignard Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1856 Lines: 39 On Thu, Aug 17, 2017 at 3:48 PM, Shuah Khan wrote: > When a test exits with skip exit code of 4, "make run_destructive_tests" > halts testing. Fix run_destructive_tests target to handle error exit codes. > > Reported-by: John Stultz > Signed-off-by: Shuah Khan > --- > tools/testing/selftests/timers/Makefile | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile > index c805ab048d26..6c1327278d5f 100644 > --- a/tools/testing/selftests/timers/Makefile > +++ b/tools/testing/selftests/timers/Makefile > @@ -13,20 +13,20 @@ TEST_GEN_PROGS_EXTENDED = alarmtimer-suspend valid-adjtimex adjtick change_skew > > include ../lib.mk > > +define RUN_DESTRUCTIVE_TESTS > + @for TEST in $(TEST_GEN_PROGS_EXTENDED); do \ > + BASENAME_TEST=`basename $$TEST`; \ > + if [ ! -x $$BASENAME_TEST ]; then \ > + echo "selftests: Warning: file $$BASENAME_TEST is not executable, correct this.";\ > + echo "selftests: $$BASENAME_TEST [FAIL]"; \ > + else \ > + cd `dirname $$TEST`; (./$$BASENAME_TEST && echo "selftests: $$BASENAME_TEST [PASS]") || echo "selftests: $$BASENAME_TEST [FAIL]"; cd -;\ > + fi; \ > + done; > +endef One more on this... you might remove rtctest_setdate from the TEST_GEN_PROGS_EXTENDED list, since it too requires arguments to test, and it wasn't a part of run_destructive_tests previously. I see Benjamin added this test not long ago, but I'm not sure exactly how he expects it to be run (just manually?). thanks -john