Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751102AbdHSG3r (ORCPT <rfc822;w@1wt.eu>);
        Sat, 19 Aug 2017 02:29:47 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:35287 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750852AbdHSG3p (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 19 Aug 2017 02:29:45 -0400
Date: Sat, 19 Aug 2017 09:29:40 +0300
From: Maksim Salau <maksim.salau@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        akpm@linux-foundation.org,
        "Alfredo Rafael Vicente Boix" <alviboi@gmail.com>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 3.16 084/134] usb: misc: legousbtower: Fix buffers on
 stack
Message-ID: <20170819092940.62513d5c@gmail.com>
In-Reply-To: <lsq.1503062000.990820443@decadent.org.uk>
References: <lsq.1503061998.818387115@decadent.org.uk>
        <lsq.1503062000.990820443@decadent.org.uk>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 592
Lines: 23

On Fri, 18 Aug 2017 14:13:20 +0100
Ben Hutchings <ben@decadent.org.uk> wrote:

> 3.16.47-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Maksim Salau <maksim.salau@gmail.com>
> 
> commit 942a48730faf149ccbf3e12ac718aee120bb3529 upstream.
> 
> Allocate buffers on HEAP instead of STACK for local structures
> that are to be received using usb_control_msg().

Hi Ben,

The change has a memory leak, which is fixed by the commit
0bd193d62b4270a2a7a09da43ad1034c7ca5b3d3
If the commit is not in your queue, please add it.

Thanks,
Maksim.