Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751861AbdHSMGC (ORCPT ); Sat, 19 Aug 2017 08:06:02 -0400 Received: from mail-lf0-f52.google.com ([209.85.215.52]:33262 "EHLO mail-lf0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbdHSMGA (ORCPT ); Sat, 19 Aug 2017 08:06:00 -0400 Subject: Re: [PATCH 2/4] gpu: host1x: Enable gather filter To: Mikko Perttunen , Mikko Perttunen , thierry.reding@gmail.com, jonathanh@nvidia.com Cc: dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170818161553.27597-1-mperttunen@nvidia.com> <20170818161553.27597-3-mperttunen@nvidia.com> <64de3b3b-7c9e-54e9-49f4-d89b3d2c5f21@kapsi.fi> From: Dmitry Osipenko Message-ID: <6298c86c-1fb5-c9dc-f8d4-92af5c5820be@gmail.com> Date: Sat, 19 Aug 2017 15:05:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <64de3b3b-7c9e-54e9-49f4-d89b3d2c5f21@kapsi.fi> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 921 Lines: 28 On 19.08.2017 13:46, Mikko Perttunen wrote: > On 08/19/2017 01:42 PM, Dmitry Osipenko wrote: >> On 18.08.2017 19:15, Mikko Perttunen wrote: >>> The gather filter is a feature present on Tegra124 and newer where the >>> hardware prevents GATHERed command buffers from executing commands >>> normally reserved for the CDMA pushbuffer which is maintained by the >>> kernel driver. >>> >>> This commit enables the gather filter on all supporting hardware. >>> >>> Signed-off-by: Mikko Perttunen >>> --- >> >> TRM says that "Invalid Gbuffer cmd" interrupt would be raised when filtering >> happens. Is that interrupt disabled by default or it would cause 'unhandled >> interrupt'? >> > > It's disabled by default. Jobs that are stopped by the filter are then handled > by the usual timeout mechanism. > Alright, then it looks good to me. Reviewed-by: Dmitry Osipenko -- Dmitry