Date: Sat, 19 Aug 2017 17:07:16 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Srishti Sharma <srishtishar@gmail.com>
Cc: ruxandra.radulescu@nxp.com, linux-kernel@vger.kernel.org,
        devel@driverdev.osuosl.org
Subject: Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple
 assignments should be avoided.
Message-ID: <20170820000716.GA15236@kroah.com>
References: <1503181885-4555-1-git-send-email-srishtishar@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1503181885-4555-1-git-send-email-srishtishar@gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1096
Lines: 29

On Sun, Aug 20, 2017 at 04:01:25AM +0530, Srishti Sharma wrote:
> Fixed a check reported by checkpatch.pl to avoid multiple assignments in a single statement.

Always wrap your changelog text at 72 columns please.

> 
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
>  drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
> index 26017fe..75e3366 100644
> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c
> @@ -1636,7 +1636,8 @@ static void set_fq_affinity(struct dpaa2_eth_priv *priv)
>  	 * This may well change at runtime, either through irqbalance or
>  	 * through direct user intervention.
>  	 */
> -	rx_cpu = txc_cpu = cpumask_first(&priv->dpio_cpumask);
> +	rx_cpu = cpumask_first(&priv->dpio_cpumask);
> +	txc_cpu = cpumask_first(&priv->dpio_cpumask);

The original code is nicer, as you don't have to do the computation
twice.

thanks,

greg k-h