Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752445AbdHTBGE (ORCPT ); Sat, 19 Aug 2017 21:06:04 -0400 Received: from mail-qk0-f193.google.com ([209.85.220.193]:37294 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751836AbdHTBGD (ORCPT ); Sat, 19 Aug 2017 21:06:03 -0400 MIME-Version: 1.0 In-Reply-To: <20170820000716.GA15236@kroah.com> References: <1503181885-4555-1-git-send-email-srishtishar@gmail.com> <20170820000716.GA15236@kroah.com> From: Srishti Sharma Date: Sun, 20 Aug 2017 06:36:02 +0530 Message-ID: Subject: Re: [PATCH] Staging: fsl-dpaa2: ethernet: dpaa2-eth.c: Multiple assignments should be avoided. To: Greg KH Cc: ruxandra.radulescu@nxp.com, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 35 On Sun, Aug 20, 2017 at 5:37 AM, Greg KH wrote: > On Sun, Aug 20, 2017 at 04:01:25AM +0530, Srishti Sharma wrote: >> Fixed a check reported by checkpatch.pl to avoid multiple assignments in a single statement. > > Always wrap your changelog text at 72 columns please. > >> >> Signed-off-by: Srishti Sharma >> --- >> drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >> index 26017fe..75e3366 100644 >> --- a/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >> +++ b/drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c >> @@ -1636,7 +1636,8 @@ static void set_fq_affinity(struct dpaa2_eth_priv *priv) >> * This may well change at runtime, either through irqbalance or >> * through direct user intervention. >> */ >> - rx_cpu = txc_cpu = cpumask_first(&priv->dpio_cpumask); >> + rx_cpu = cpumask_first(&priv->dpio_cpumask); >> + txc_cpu = cpumask_first(&priv->dpio_cpumask); > > The original code is nicer, as you don't have to do the computation > twice. > > thanks, > > greg k-h Okay, Thanks :) Regards, Srishti