Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566AbdHTCNA (ORCPT ); Sat, 19 Aug 2017 22:13:00 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:40658 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480AbdHTCM6 (ORCPT ); Sat, 19 Aug 2017 22:12:58 -0400 Subject: Re: [PATCH net-next v3] arm: eBPF JIT compiler To: Shubham Bansal References: <1503134429-29063-1-git-send-email-illusionist.neo@gmail.com> <9d77730f-c6a8-b337-599e-5919207a7e0a@fb.com> CC: Russell King - ARM Linux , David Miller , Network Development , Daniel Borkmann , , LKML , Kees Cook , Andrew Lunn From: Alexei Starovoitov Message-ID: Date: Sat, 19 Aug 2017 19:11:51 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [2620:10d:c090:180::1:15a8] X-ClientProxiedBy: BN6PR10CA0038.namprd10.prod.outlook.com (2603:10b6:404:109::24) To BL2PR15MB0961.namprd15.prod.outlook.com (2603:10b6:201:15::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b8562ca-e58c-4ff9-786c-08d4e770d56b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:BL2PR15MB0961; X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;3:NrX+zU0YzETyBivXNfcXoV3WcVbEYNu1vEupNtyISuRqdjmJc/I2Cun4Sg0/ZpSOFLZrxgpeUy9OncADFt6gNC6OvFoUxGhpyBEW/3mkf9aDpDRqkPl6rxHKfxHtpGhCZ0AuHUbTsgToO8mM9rEngObaQnlrqbV+eYvyLnnOXWrHnc5NEbaozNWoFD05oGCIkmDeDzDieRFdPekWt5JT1wI4kUReiV16eGpSKho46AUhjs4jab/uC1SAEhA2M1Z1;25:aMy6Idc46Gbe3d5G7FQC6MLNefXhqJW+AafI7MP+JoPrcibUjwpQZGKRWL4dJa4Z2Ke6fscXO2SlPdKC9tkSUSzWRIav6oVPy2OGGgu+0x+KwfhwbH+7LExWFBHaFQ5IpqZSmxeEEuaa562QlEwcJz92wRPOiR6GRPypFeDhM/uQxaEMivOhV3b4a4zLxcvIRRKSOE3NAP1EAqzsZjfQl1PGoOQiUDQhWoYJJHMrscx48srr+QheTiSwNVGxKsU89qg/76VZ0HImF+IQo5pHA9wPaW95m8xoneLqVAcMlB4PS+bsvOJdgUa6xiCzDEGqnh9pIqamxgCLVSyJqx8KXQ==;31:QqF0RJsgOUnzn4tDa2K/IYM9Vx2xldwSDbv4qAt/sVYEZL5qy1K04EQZJDo3qlZgltJ3PwD7HAALspG0XEtz0IPaYg+L44+XPROqAuZraxkBKr9P9lz9Gce8ghGQAV31N2eQb/hfVJeX8SvPuCsBJffkSWJmHHLQtMzVz+H/r7U5klcY7V0OvG+g5pO9eEpVijhtQgiiUzKGl1YiSI/5Apb89ti47lCAt/HUKjH+qts= X-MS-TrafficTypeDiagnostic: BL2PR15MB0961: X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;20:X0tdOu0XW2q/OuFJqO+6QpOy9z9Ad7oNU3q7eIhNfqzLEZz+hrZjool4KTMUmv/u5BvrPM2/pJowaFhb8eVLEP9it7JVYViovMnk4MojgoXeMc+S2fE18jTQu4fc2MlSNMCexrc1sc9tDxABYrxx3vNlf4BS+QOaKo+3FooaYv6iRW8eADycQ2FP5zk9gb4PU8vyFWGdP+bjD2zR9Qk0dmT7xT2KeleqKLd2zYmeHOKypaNv8xcekPZ4iLjb65VwT9HZCMoikbUC3WLw4NQWsKQYyehZk3VT7QvvfLyyKmDqVBiRNDAXU1e4ClgHAv7sN+mYV5Moln5jTfTxFj5YcqvC/Ua/hELJUGR19Cx6/oHKWIzq93K6QarO/z94qF/jpcSdYWdxd76M78/uIQj/gAeZB775BptS+U9RsjzxX79zt6YI47DkNsd4vs/jnFcuO8IkeR/p2Ub9GIfkre77mAneVAXVuoos3cpbkqPOW9JVQPZHEJYudXVxK+9WA6xH;4:KpTEfQT8Alxlo3xg5cPd1we27cxv4MWS9362tm2KHEItQHpGDwg0W0SWakeUof06IXOBoYGuhEX1aEqsVt5YHmmliNuOdHEJv08yYgfohnv4vwnHF0q2YEQIWwM+yTuu6YKcbHuCujLeDikzkW99mCj49mOJPL4mmz9kgWKFPMa8aoIe4+S/Xl+7iCtKiXWxDtQRHCwwibFI0JTJrKWVK+VnxmLc7050rgEUxPerWsre2D0ryoYQ0Kdux+J9lyDT X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(20161123562025)(20161123564025)(20161123560025)(20161123558100)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:BL2PR15MB0961;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:BL2PR15MB0961; X-Forefront-PRVS: 040513D301 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(7370300001)(4630300001)(6009001)(24454002)(189002)(377454003)(199003)(65826007)(68736007)(305945005)(7736002)(83506001)(36756003)(4001350100001)(229853002)(7350300001)(33646002)(189998001)(47776003)(5660300001)(93886005)(81156014)(8676002)(97736004)(53546010)(81166006)(65806001)(65956001)(50986999)(42186005)(110136004)(6246003)(54356999)(76176999)(53936002)(54906002)(31696002)(6486002)(4326008)(101416001)(105586002)(478600001)(2950100002)(106356001)(6916009)(6666003)(1706002)(31686004)(86362001)(2906002)(6116002)(64126003)(23676002)(25786009)(50466002)(230700001)(42262002);DIR:OUT;SFP:1102;SCL:1;SRVR:BL2PR15MB0961;H:[IPv6:2620:10d:c081:1132::10a4];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjE1TUIwOTYxOzIzOklmZkJHKzkxbnNxL0lRS0RyNmdxVXB4U2tE?= =?utf-8?B?NW5rejdKQmhhcmFJMHJlcktIV3lxalVNMUVjV245cmx6NjUrR241VFVkMkh5?= =?utf-8?B?WmxrSzFPa3VMM0pxRmJPSjBTRksxZ0xieTIwNFNFTmpuSlM1NlQ1NXY5WmJW?= =?utf-8?B?aERDbEN6d1RNM1BJYU4xcndST3ArVzFaNG1rUHltak5MODRDdjFMWDRscGh5?= =?utf-8?B?MS9wQmZQWjkvMll3cU5wT0FDaW1yVDJ4NEozRWtrQ0pwWVpGZ05KY1BzUjJr?= =?utf-8?B?ZWlkTEJUS2F0TXdPdnJVR3BOb28rU3A1NUVzUWdlZ1NNNG9zT2JNeENjeGFv?= =?utf-8?B?SHlraVVmVDFKa3RIZGlZUjRJWmNPRWt1ejFvc2lNb2FyaWgxZ3puNTZUUGZ2?= =?utf-8?B?b2tvRlZhT3orMGNDNkhJL0M5OEF5VUFXeGxtRVV3cmZ6ZXhxd0t0YWs2ZmJC?= =?utf-8?B?Z29QSjZCV0FTN2svOFFPQ1NRbzFtNDcvVXU3VFV1d3UycHQ1WmJLUWE4a1M0?= =?utf-8?B?bkR0TWNCRmNIbytZWEdiL1JQUzBwazZ1VGtJRnJmVGZ5Z0R1ZFpoL2tzckFL?= =?utf-8?B?Rms5NE5pb21UQTdFL1RJb2ZsY0tTOG04c0lrcFRPVUhGYzhPQllYa0dGNjBZ?= =?utf-8?B?WnAvMmMvcytCTnI3aDluY1BtRDBERjN0YU8vRjdSSVR0bEE5K1R2YWM2U0Vz?= =?utf-8?B?N3JsS3QzL2ZVNzBNUkFzUWRDaHA1c1lGMGhHZ0FVUXFCUWJtVEZmVTEyc2h4?= =?utf-8?B?eHp4N3AyeUdJT2lFOGF3d3FidTlZL0hIbVBscnRJSHpubDZXcjNEZ0U2T1li?= =?utf-8?B?dkxRak9LMjhzRTZpdEE5ZWpTZkNNQnJZZXVBN1RoN1U3Y3Ivb0dUTkMycXEr?= =?utf-8?B?MXl2ZnY0L2ovejVjWUFLbHV1MFpFTzZZS2dza0lJS2lsWHhpS0dlR3JCOGRN?= =?utf-8?B?NG1uUXZ4b0YvVjFjTWhRcWN5RlNPb0hEY21NOTFNUEFzTTRsMitCVWxYS2t4?= =?utf-8?B?QkJEbzVIY08rRlV6N3JUQWN1bjN3WVVhUUJOVmtxZmgreklzdDNqY1Qzdm85?= =?utf-8?B?S1NDZUVKS0xrRVRXRWhUN1d6aU8rdkh3M0VaNlNqa2NMK2g4dThKVC80aFBZ?= =?utf-8?B?cWtNOVFGalBoTXgvTWZrM0F1c2VseTB4Tk9tK29FYy9pUU1aeE4yL2NpMXR0?= =?utf-8?B?NUNpZkhJSTA4QTNUQk1ubXdwakZiZ1FpN3V0bEk4QkRXcG8rUjQ2OUtMaUp5?= =?utf-8?B?RDdqaUI2aFQ5ZVJ0SjlBQTVLLzVyVWNzLzB0WXdnOXhnRWE4T0t2a2IwYkpm?= =?utf-8?B?UWMxWXVnU0tOK3NjQTIzN3JVbnlRc2ZKdjdGWW82c1VjbmM2NHNPTWN4d1Q4?= =?utf-8?B?c1NTdWZzMnE3MEh3TnllYnBEQVJSbElqUWh1Q3pGaS9OclY1YXV6V05FUnRG?= =?utf-8?B?KzNLQVJ2cWlucm8rVkowVXFWOVpUZmhTanNiUDQ0Vk1sT3F0TzczMXM4TlZI?= =?utf-8?B?Y05vbHJFM0dLOEowNTZqS2ZuazFGeDFMck56Mkx3VEwyWHQ2RGJ2NkhDLzN1?= =?utf-8?B?V3NRb2RMRnhzZkRaYUN3MjExVllBYmFxTjdPL291UW4waFNNcUUvL01KVlY2?= =?utf-8?B?c2NXbU14K3V6a1FsNjRoN0FHTGxOL0hqOWRLNFg2UDZsenluMnRsOVRUQW1Y?= =?utf-8?B?UlpqdXRabE1aSm5EOEZWdE90SmI2bXFRVUJjYnlSQS9KVzg1a1QzSkhacVVO?= =?utf-8?B?MmwvQ3FxVVMrMkQ2ekwxWnJzMVFZRG0vM09OMzcyRmllWHFZQWlPRWErSzcz?= =?utf-8?B?UDdyZnVsZmx1RjdBLy9sUitEbGwyc1dDM1hIK0VrTHFqS3FuY29ZQVNQSHd1?= =?utf-8?Q?g4b7iOvXACA=3D?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;6:PV3JDtgKNd2aa++FgrzVX3AHLWpF8sjbNlPW6GiZpGV08Rkvwt5Ot3dqjzVDJPuT3wgFEFDis87omeVfKIw1S877QD0sgecZOmTx408dwYUzPAYYgqHYGc462TJSBwmA8B6hlKTuAe1csBDjVm0iVWYXg2iTC6bP7NYxbXJ023u3H1SLLOs+Ar7Lqg9d7GZO/eLTLGVMBPiYrfPc4U43kgwrMwjwppaEEb4EAsBw87xsP6x/Hv3wQHpgDBg5G8WOcWg3lw+uHpecZkXL97kVlEn1V+ZnYDs0fuvHPAl9KSXmN/fMm0rVTGpyNMHfUkKBNbtVtgfOxkoUtwq0jtR7rQ==;5:cQ1UdXgeFzI95lGcKxFAqI5gPA4GSxc7vdxtofyX8WTo4m1wZ7iK8eWdsFybP2REEVwISkzpL1Us9rbR9PPtuMBcvNMz/tJd5oaUfqtO6HDTUJXfYti1kW+RP9HgozyjdObe7f6OFAgk/4Ex/okkMw==;24:IyCcz5mKsaE1JM6iqDTpqOJJABM0XTsZ9asjyi7iVYlLwHn/Ra1aqHg+KNqzKiOD5pCQiCRai2uSplWWKRjev0c1ZRqjoinfxItaNYN70aA=;7:lgZ4YMIqTUqIVqBb13hoD4yj8QfGw/B9gRQmxfwan+ib48PAlGvQbRHl6sWdEiyqtz53GLkeEyzBi76kuI1r2PelAf8R4ds7QPJ8C45ite0u5f53NdZwKYKwqqCiq4Cj3LC/Xyu3CFXvpNsxIpr78qk3uoY9kzy28SLcEl3Y502mQNFa8pr5nYgCS6RajkJPlW1X0ErWVo/fVuMFrC+nq4FfxD3lFRs9paA84CcNtYU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR15MB0961;20:9gOVCi3ARuPWKY0fLFVv9ej/yaH7kMO3GOi57jMoEk2pngcBhRk5hsWI2vd7nIlwbNcF8JVgdGntcDI6OavGyK8zrAzfqAGu8T0Cs0s7xhdEkued7SDuET8BkPu8rKNXCqebDFIaeQ4PFV7Mc+y2jWMuxdYcyJWH/V7qZ9oYk08= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2017 02:11:55.6057 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR15MB0961 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-19_13:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 19 On 8/19/17 2:46 PM, Shubham Bansal wrote: > test_pkt_access:PASS:ipv4 271 nsec > test_pkt_access:PASS:ipv6 297 nsec > test_xdp:PASS:ipv4 961517 nsec <--- Here is the difference. > test_xdp:PASS:ipv6 615855 nsec <--- Here is the difference. yes. this is expected. These two numbers are single run on cold cache, so there will be run-to-run variation. > test_l4lb:PASS:ipv4 3049 nsec > test_l4lb:PASS:ipv6 3906 nsec These two and the first two were the ones I was interested in, since they do many iterations over the same set and the best to compare code gen changes. The delta % is actually better than I expected judging by test_bpf micro-benchmarks, so the results are very encouraging. Thanks!