Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbdHTCwe (ORCPT ); Sat, 19 Aug 2017 22:52:34 -0400 Received: from casper.infradead.org ([85.118.1.10]:38704 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbdHTCwd (ORCPT ); Sat, 19 Aug 2017 22:52:33 -0400 Date: Sun, 20 Aug 2017 03:52:26 +0100 (BST) From: James Simmons To: "Dilger, Andreas" cc: Greg KH , Cihangir Akturk , Lustre Development List , "devel@driverdev.osuosl.org" , Linux Kernel Mailing List , "Drokin, Oleg" Subject: Re: [PATCH] staging: lustre: fix structure size for ARM OABI In-Reply-To: Message-ID: References: <1502894655-9731-1-git-send-email-cakturk@gmail.com> <20170817162639.GA13066@kroah.com> User-Agent: Alpine 2.20 (LFD 67 2015-01-07) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="1985284609-376706392-1503197546=:5810" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170820_035226_365633_1CBDE3EC X-CRM114-Status: GOOD ( 15.48 ) X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.4.1 on casper.infradead.org summary: Content analysis details: (-1.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 NO_RELAYS Informational: message was not relayed via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1423 Lines: 36 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1985284609-376706392-1503197546=:5810 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT > On Aug 17, 2017, at 10:26, Greg KH wrote: > > > > On Wed, Aug 16, 2017 at 05:44:15PM +0300, Cihangir Akturk wrote: > >> When building the kernel for the ARM architecture without setting > >> CONFIG_AEABI, size of struct lov_user_md_v3 and struct lov_mds_md_v3 > >> differs, due to different alignment requirements of OABI and EABI. I have to ask are you testing the lustre on ARM? > >> Marking the anonymous union within struct lov_user_md_v3 as > >> '_packed' solves this issue. Otherwise we get the following > >> error: > >> > >> drivers/staging/lustre/lustre/lov/lov_pack.c:352:2: note: in expansion > >> of macro ‘BUILD_BUG_ON’ > >> BUILD_BUG_ON(sizeof(lum) != sizeof(struct lov_mds_md_v3)); > >> > >> Signed-off-by: Cihangir Akturk > >> --- > >> drivers/staging/lustre/lustre/include/lustre/lustre_user.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > This file is no longer in the tree :( > > With James' recent patch series, this has moved to include/uapi/linux/lustre/lustre_user.h BTW is __packed valid for UAPI headers? --1985284609-376706392-1503197546=:5810--