Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752769AbdHTJRo (ORCPT ); Sun, 20 Aug 2017 05:17:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:47308 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696AbdHTJRm (ORCPT ); Sun, 20 Aug 2017 05:17:42 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BDCE7218F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 20 Aug 2017 10:16:17 +0100 From: Jonathan Cameron To: Arvind Yadav Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 1/3] iio: accel: bma180: constify i2c_device_id Message-ID: <20170820101617.476bba9a@archlinux> In-Reply-To: <1503168458-17676-2-git-send-email-arvind.yadav.cs@gmail.com> References: <1503168458-17676-1-git-send-email-arvind.yadav.cs@gmail.com> <1503168458-17676-2-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1033 Lines: 31 On Sun, 20 Aug 2017 00:17:36 +0530 Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by work with > const i2c_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/bma180.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c > index efc6773..3dec972 100644 > --- a/drivers/iio/accel/bma180.c > +++ b/drivers/iio/accel/bma180.c > @@ -842,7 +842,7 @@ static SIMPLE_DEV_PM_OPS(bma180_pm_ops, bma180_suspend, bma180_resume); > #define BMA180_PM_OPS NULL > #endif > > -static struct i2c_device_id bma180_ids[] = { > +static const struct i2c_device_id bma180_ids[] = { > { "bma180", BMA180 }, > { "bma250", BMA250 }, > { }