Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752800AbdHTJRq (ORCPT ); Sun, 20 Aug 2017 05:17:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:47316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbdHTJRo (ORCPT ); Sun, 20 Aug 2017 05:17:44 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D2B722195B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=jic23@kernel.org Date: Sun, 20 Aug 2017 10:17:02 +0100 From: Jonathan Cameron To: Arvind Yadav Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org Subject: Re: [PATCH 2/3] iio: light: apds9300: constify i2c_device_id Message-ID: <20170820101702.6cd1242e@archlinux> In-Reply-To: <1503168458-17676-3-git-send-email-arvind.yadav.cs@gmail.com> References: <1503168458-17676-1-git-send-email-arvind.yadav.cs@gmail.com> <1503168458-17676-3-git-send-email-arvind.yadav.cs@gmail.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 30 On Sun, 20 Aug 2017 00:17:37 +0530 Arvind Yadav wrote: > i2c_device_id are not supposed to change at runtime. All functions > working with i2c_device_id provided by work with > const i2c_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied. Thanks, Jonathan > --- > drivers/iio/light/apds9300.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/light/apds9300.c b/drivers/iio/light/apds9300.c > index 649b26f..05eacd1 100644 > --- a/drivers/iio/light/apds9300.c > +++ b/drivers/iio/light/apds9300.c > @@ -505,7 +505,7 @@ static SIMPLE_DEV_PM_OPS(apds9300_pm_ops, apds9300_suspend, apds9300_resume); > #define APDS9300_PM_OPS NULL > #endif > > -static struct i2c_device_id apds9300_id[] = { > +static const struct i2c_device_id apds9300_id[] = { > { APDS9300_DRV_NAME, 0 }, > { } > };