Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753437AbdHTWQI (ORCPT ); Sun, 20 Aug 2017 18:16:08 -0400 Received: from mail-ua0-f173.google.com ([209.85.217.173]:38609 "EHLO mail-ua0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753335AbdHTWQH (ORCPT ); Sun, 20 Aug 2017 18:16:07 -0400 MIME-Version: 1.0 In-Reply-To: <599A0961.3010300@iogearbox.net> References: <1503134429-29063-1-git-send-email-illusionist.neo@gmail.com> <599A0961.3010300@iogearbox.net> From: Shubham Bansal Date: Mon, 21 Aug 2017 03:46:05 +0530 Message-ID: Subject: Re: [PATCH net-next v3] arm: eBPF JIT compiler To: Daniel Borkmann Cc: Russell King - ARM Linux , David Miller , Network Development , Alexei Starovoitov , linux-arm-kernel@lists.infradead.org, LKML , Kees Cook , Andrew Lunn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 12 > With the below #ifdef __LITTLE_ENDIAN spanning the entire > bpf_int_jit_compile(), a user can then enable and compile > eBPF JIT for big endian, even set the bpf_jit_enable to 1 > to turn it on, but it won't JIT anything, which is contrary > to the expectation. > > This should rather be a hard dependency in the Kconfig, if > I got it correctly, expressed as e.g. > > select HAVE_EBPF_JIT if !CPU_ENDIAN_BE32 Will do it. That's a good catch. Thanks Daniel.