Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751177AbdHUDlm (ORCPT ); Sun, 20 Aug 2017 23:41:42 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50072 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbdHUDll (ORCPT ); Sun, 20 Aug 2017 23:41:41 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AAF4F60262 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=anjiandi@codeaurora.org Subject: Re: [PATCH] tpm/tpm_crb: Access locality for non-ACPI and non-SMC start method To: Jarkko Sakkinen References: <1503029736-591-1-git-send-email-anjiandi@codeaurora.org> <20170819170500.xayh6pzidl5ury2d@linux.intel.com> Cc: peterhuewe@gmx.de, tpmdd@selhorst.net, jgunthorpe@obsidianresearch.com, tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Jiandi An Message-ID: <424ce770-e21b-749c-df5c-b12a2691269e@codeaurora.org> Date: Sun, 20 Aug 2017 22:41:38 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170819170500.xayh6pzidl5ury2d@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1544 Lines: 46 On 08/19/2017 12:05 PM, Jarkko Sakkinen wrote: > On Thu, Aug 17, 2017 at 11:15:36PM -0500, Jiandi An wrote: >> For ARM64, the locality is handled by Trust Zone in FW. >> The layout does not have crb_regs_head. It is hitting >> the following line. >> dev_warn(dev, FW_BUG "Bad ACPI memory layout"); >> >> Current code excludes CRB_FL_ACPI_START and when >> CRB_FL_CRB_SMC_START is added around the same time >> locality support is added, it should also be excluded. >> >> For goIdle and cmdReady where code was excluding >> CRB_FL_ACPI_START only (do nothing for ACPI start method), >> CRB_FL_CRB_SMC_START was also excluded as ARM64 SMC start >> method does not have TPM_CRB_CTRL_REQ. >> Change if confition to white list instead of black list. >> >> Signed-off-by: Jiandi An > > Is this v2? If so, where is the change log? Based on the previous comments, I now understand that because of Intel PTT bug workaround, it is not appropriate for the patch to have title/subject "Access locality for only CRB_START method" So the more descriptive patch title is "Access locality for only non-ACPI and non-SMC start method". Because the patch is changed, I thought I start a new series. Would you like me to tag this v3 and put change log even though patch title has changed? Thanks - Jiandi > > /Jarkko > -- Jiandi An Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.