Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751145AbdHUFpc (ORCPT ); Mon, 21 Aug 2017 01:45:32 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:19462 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdHUFpb (ORCPT ); Mon, 21 Aug 2017 01:45:31 -0400 Subject: Re: [PATCH v2] soc: ti: knav: Add a NULL pointer check for kdev in knav_pool_create To: "arm@kernel.org" , Arnd Bergmann Cc: Keerthy , ssantosh@kernel.org, m-karicheri2@ti.com, t-kristo@ti.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1501475496-10267-1-git-send-email-j-keerthy@ti.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: <2f826631-68d2-6a7e-a656-9c8e67ee8337@oracle.com> Date: Sun, 20 Aug 2017 22:44:51 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1501475496-10267-1-git-send-email-j-keerthy@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 534 Lines: 17 Hi Arnd, On 7/30/17 9:31 PM, Keerthy wrote: > knav_pool_create is an exported function. In the event of a call > before knav_queue_probe, we encounter a NULL pointer dereference > in the following line. Hence return -EPROBE_DEFER to the caller till > the kdev pointer is non-NULL. > > Signed-off-by: Keerthy > --- > > Changes in v2: > > * Fixed returning an int to returning pointer. FWIW, Acked-by: Santosh Shilimkar Can you please also apply this fix in your fixes branch ?