Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751094AbdHUGFX (ORCPT ); Mon, 21 Aug 2017 02:05:23 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:45102 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbdHUGFV (ORCPT ); Mon, 21 Aug 2017 02:05:21 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4097960376 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=aneela@codeaurora.org Subject: Re: [PATCH 1/3] soc: qcom: smem: Support global partition To: Chris Lew , bjorn.andersson@linaro.org, andy.gross@linaro.org, david.brown@linaro.org Cc: linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <1503018948-26629-1-git-send-email-clew@codeaurora.org> <1503018948-26629-2-git-send-email-clew@codeaurora.org> From: Arun Kumar Neelakantam Message-ID: <1653d6e0-e62d-f341-3911-bd2b307ba885@codeaurora.org> Date: Mon, 21 Aug 2017 11:35:15 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1503018948-26629-2-git-send-email-clew@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 492 Lines: 16 On 8/18/2017 6:45 AM, Chris Lew wrote: > @@ -782,7 +855,10 @@ static int qcom_smem_probe(struct platform_device *pdev) > } > > version = qcom_smem_get_sbl_version(smem); > - if (version >> 16 != SMEM_EXPECTED_VERSION) { > + switch (version >> 16) { > + case SMEM_GLOBAL_PART_VERSION: > + case SMEM_GLOBAL_HEAP_VERSION: break statement is needed for supported versions > + default: > dev_err(&pdev->dev, "Unsupported SMEM version 0x%x\n", version); > return -EINVAL; > }