Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752535AbdHUHpR (ORCPT ); Mon, 21 Aug 2017 03:45:17 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:37628 "EHLO mail-wr0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbdHUHpQ (ORCPT ); Mon, 21 Aug 2017 03:45:16 -0400 Date: Mon, 21 Aug 2017 08:45:12 +0100 From: Lee Jones To: Arvind Yadav Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: t7l66xb: Handle return value of clk_prepare_enable Message-ID: <20170821074512.bre57qc34i2j5pdn@dell> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 510 Lines: 17 On Tue, 08 Aug 2017, Arvind Yadav wrote: > clk_prepare_enable() can fail here and we must check its return value. > we must disable clock, if t7l66xb_probe is not successful. > > Signed-off-by: Arvind Yadav > --- > drivers/mfd/t7l66xb.c | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) Applied, thanks. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog