Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752519AbdHUIJz (ORCPT ); Mon, 21 Aug 2017 04:09:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51454 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbdHUIJy (ORCPT ); Mon, 21 Aug 2017 04:09:54 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C20A860711 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=bgoswami@codeaurora.org Date: Mon, 21 Aug 2017 01:09:49 -0700 From: Banajit Goswami To: Peng Donglin Cc: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, plai@codeaurora.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 09/12] ASoC: qcom: Remove unnecessary function call Message-ID: <20170821080949.GB8000@codeaurora.org> References: <1503207898-16378-1-git-send-email-dolinux.peng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1503207898-16378-1-git-send-email-dolinux.peng@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 34 On Sun, Aug 20, 2017 at 01:44:58PM +0800, Peng Donglin wrote: > First of all,the address of pdev->dev is assigned to card->dev,then > the function platform_set_drvdata copies the value the variable card > to pdev->dev.driver_data, but when calling snd_soc_register_card,the > function dev_set_drvdata(card->dev, card) will also do the same copy > operation,so i think that the former copy operation can be removed. > > Signed-off-by: Peng Donglin Acked-by: Banajit Goswami > --- > sound/soc/qcom/storm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/qcom/storm.c b/sound/soc/qcom/storm.c > index c5207af..a9fa972 100644 > --- a/sound/soc/qcom/storm.c > +++ b/sound/soc/qcom/storm.c > @@ -99,7 +99,6 @@ static int storm_platform_probe(struct platform_device *pdev) > return -ENOMEM; > > card->dev = &pdev->dev; > - platform_set_drvdata(pdev, card); > > ret = snd_soc_of_parse_card_name(card, "qcom,model"); > if (ret) { > -- > 1.9.1 > > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel