From: Daniel Baluta <daniel.baluta@nxp.com>
To: "kuninori.morimoto.gx@renesas.com" <kuninori.morimoto.gx@renesas.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "S.j. Wang" <shengjiu.wang@nxp.com>,
        Mihai Serban <mihai.serban@nxp.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Viorel Suman <viorel.suman@nxp.com>
Subject: Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets
Thread-Topic: [PATCH] ASoC: simple-scu-card: Parse off codec widgets
Thread-Index: AQHTEqvdZc1VZNfK6E2WjeyX3dpeG6KOB7EAgACCyQA=
Date: Mon, 21 Aug 2017 08:31:41 +0000
Message-ID: <1503304300.24887.78.camel@nxp.com>
References: <1502460739-12134-1-git-send-email-daniel.baluta@nxp.com>
         <87inhhdaeh.wl%kuninori.morimoto.gx@renesas.com>
In-Reply-To: <87inhhdaeh.wl%kuninori.morimoto.gx@renesas.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <4DFA77F0B53FA546842762A8747D0799@eurprd04.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Aug 2017 08:31:41.6203
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR04MB398
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v7L8VtGE011582
Content-Length: 1644
Lines: 32

On Lu, 2017-08-21 at 00:43 +0000, Kuninori Morimoto wrote:
> Hi
> 
> > 
> > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 +
> >  sound/soc/generic/simple-scu-card.c                         | 4 ++++
> >  2 files changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/simple-scu-card.txt b/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> > index 327d229..32f8dbc 100644
> > --- a/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> > +++ b/Documentation/devicetree/bindings/sound/simple-scu-card.txt
> > @@ -24,6 +24,7 @@ Optional subnode properties:
> >  - simple-audio-card,convert-rate	: platform specified sampling rate convert
> >  - simple-audio-card,convert-channels	: platform specified converted channel size (2 - 8 ch)
> >  - simple-audio-card,prefix		: see routing
> > +- simple-audio-card,widgets		: Please refer to widgets.txt.
> >  - simple-audio-card,routing		: A list of the connections between audio components.
> >  					  Each entry is a pair of strings, the first being the connection's sink,
> >  					  the second being the connection's source. Valid names for sources.
> It can be "see simple-audio-card.txt" same as other properties.
> Not a big deal though
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks for having a look. I don't have a strong preference, but given that
the patch was already pushed and when you'll go to simple-audio-card.txt it
will point you to widgets.txt we can leave it like that.

Daniel.