Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752695AbdHUJFd (ORCPT ); Mon, 21 Aug 2017 05:05:33 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:37010 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240AbdHUJFb (ORCPT ); Mon, 21 Aug 2017 05:05:31 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v7L95JqD028914 X-Nifty-SrcIP: [209.85.161.180] MIME-Version: 1.0 In-Reply-To: <20170821084930.GA7678@ulmo> References: <1503209051-16477-1-git-send-email-yamada.masahiro@socionext.com> <20170821084930.GA7678@ulmo> From: Masahiro Yamada Date: Mon, 21 Aug 2017 18:04:38 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] kbuild: use $(abspath ...) instead of $(shell cd ... && /bin/pwd) To: Thierry Reding Cc: Linux Kbuild mailing list , =?UTF-8?Q?Bj=C3=B8rn_Forsman?= , Sam Ravnborg , Michal Marek , linux-pm@vger.kernel.org, Kieran Bingham , Linux Kernel Mailing List , Thomas Renninger , Josh Poimboeuf , Arnaldo Carvalho de Melo , Jan Kiszka Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1788 Lines: 59 2017-08-21 17:49 GMT+09:00 Thierry Reding : > On Sun, Aug 20, 2017 at 03:04:11PM +0900, Masahiro Yamada wrote: >> Kbuild conventionally uses $(shell cd ... && /bin/pwd) idiom to get >> the absolute path of the directory because GNU Make 3.80, the minimal >> supported version at that time, did not support $(abspath ...) or >> $(realpath ...). >> >> Commit 37d69ee30808 ("docs: bump minimal GNU Make version to 3.81") >> dropped the GNU Make 3.80 support, so we are now allowed to use those >> make-builtin helpers. >> >> This conversion will provide better portability without relying on >> the pwd command or its location /bin/pwd. >> >> I am intentionally using $(realpath ...) instead $(abspath ...) in >> some places. The difference between the two is $(realpath ...) >> returns an empty string if the given path does not exist. It is >> convenient in places where we need to error-out if the makefile fails >> to create an output directory. >> >> Signed-off-by: Masahiro Yamada >> --- >> >> Makefile | 12 ++++++------ >> scripts/gdb/linux/Makefile | 2 +- >> tools/power/cpupower/Makefile | 2 +- >> tools/scripts/Makefile.include | 6 +++--- >> 4 files changed, 11 insertions(+), 11 deletions(-) > > This looks very similar to a patch I had written a long time ago: > > Acked-by: Thierry Reding Yup. Three month ago, I sent a reminder to you, but I did not get a response. https://lkml.org/lkml/2017/5/18/1370 This time, Bjorn sent a patch to replace /bin/pwd with pwd. I asked him to use $(abspath ...) / $(realpath ...), but he did not like to do it. https://patchwork.kernel.org/patch/9859591/ So, I am doing it by myself. -- Best Regards Masahiro Yamada